Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/merge-main@195440f #1241

Merged
merged 11 commits into from
May 13, 2022
Merged

chore/merge-main@195440f #1241

merged 11 commits into from
May 13, 2022

Conversation

julien-deramond
Copy link
Member

Closing #1214 in favor of this one more complete. I'll copy the description of the another in this one.

@julien-deramond julien-deramond added v5 merge Sync with Bootstrap skip:ci labels May 6, 2022
louismaximepiton
louismaximepiton requested changes May 9, 2022
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not checked accessibility, content, and CSS that deep.
.table-guidelines could be removed as well

site/layouts/partials/home/masthead.html Show resolved Hide resolved
site/layouts/partials/home/masthead.html Show resolved Hide resolved
site/layouts/partials/home/masthead-followup.html Show resolved Hide resolved
site/layouts/partials/home/masthead.html Show resolved Hide resolved
site/layouts/partials/home/masthead-followup.html Show resolved Hide resolved
site/assets/scss/_layout.scss Show resolved Hide resolved
site/assets/scss/_layout.scss
///////////////////////////////////////////////
///////////////////////////////////////////////
///////////////////////////////////////////////
// TODO: check me! Not sure what's the purpose of --bs-gutter-x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here to reduce the size of the container I guess ?

site/assets/scss/_component-examples.scss Outdated Show resolved Hide resolved
site/assets/scss/_clipboard-js.scss Show resolved Hide resolved
site/content/docs/5.1/components/offcanvas.md Outdated Show resolved Hide resolved
@julien-deramond julien-deramond mentioned this pull request May 11, 2022
Merged
71 tasks
@louismaximepiton louismaximepiton mentioned this pull request May 11, 2022
Closed
75 tasks
@netlify
Copy link

netlify bot commented May 13, 2022 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 8dfe482
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/627e634285e7980008e72494
😎 Deploy Preview https://deploy-preview-1241--boosted.netlify.app/docs/5.1/examples/navbars-offcanvas
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond
Copy link
Member Author

Dropped <div class="position-fixed"><input type="text"></div> via 1abc874 to avoid pa11y errors. Need to ask to Bootstrap what's the purpose of it 🤷

@julien-deramond
Copy link
Member Author

.bd-search can maybe be remove from .pa11yci.json

@julien-deramond julien-deramond marked this pull request as ready for review May 13, 2022 13:55
@julien-deramond julien-deramond merged commit 1266609 into main May 13, 2022
@julien-deramond julien-deramond deleted the main-jd-refactor-design-doc branch May 13, 2022 14:05
@julien-deramond julien-deramond mentioned this pull request May 13, 2022
Merged
77 tasks
louismaximepiton added a commit that referenced this pull request May 18, 2022
@louismaximepiton
Fix #1241 (comment), Boosted alignment
d99a96a
louismaximepiton added a commit that referenced this pull request May 18, 2022
@louismaximepiton
Fix #1241 (comment), fixes also doc issues
6c39b96
louismaximepiton added a commit that referenced this pull request May 18, 2022
@louismaximepiton
Fix #1241 (comment)
8101afd
louismaximepiton added a commit that referenced this pull request May 18, 2022
@louismaximepiton
Fix #1241 (comment) subnav sticky
d611746
louismaximepiton added a commit that referenced this pull request May 18, 2022
@louismaximepiton
Fix #1241 (comment) icons
0ef6d26
louismaximepiton added a commit that referenced this pull request May 18, 2022
@louismaximepiton
Fix #1241 (comment), useless hr
a7d0658
louismaximepiton added a commit that referenced this pull request May 18, 2022
@louismaximepiton
Fix #1241 (comment), Reintroduce title bars + realign text below
f11f37a
louismaximepiton added a commit that referenced this pull request May 18, 2022
@louismaximepiton
Fix #1241 (comment) toc toggle
19ac792
louismaximepiton added a commit that referenced this pull request May 18, 2022
@louismaximepiton
Fix #1241 (comment), migration border
6331beb
louismaximepiton added a commit that referenced this pull request May 18, 2022
@louismaximepiton
Fix #1241 (comment), subnav in header + css
883a456
louismaximepiton added a commit that referenced this pull request May 19, 2022
@louismaximepiton
Fix #1241 (comment), changing css of algolia
b8bfb89
louismaximepiton added a commit that referenced this pull request May 19, 2022
@louismaximepiton
Fix max-width #1241 (comment)
33296b1
louismaximepiton added a commit that referenced this pull request May 19, 2022
@louismaximepiton
Fix pa11yci.json #1241 (comment)
9d24246
hannahiss pushed a commit that referenced this pull request May 19, 2022
@julien-deramond @louismaximepiton @hannahiss
chore/merge-main@dd19bf2 (#1241)
2bad475 
Co-authored-by: Louis Maxime Piton <louismaxime.piton@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
merge Sync with Bootstrap v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-deramond @louismaximepiton