Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stepped process line-height #1347

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Fix stepped process line-height #1347

merged 1 commit into from
Jul 19, 2022

Conversation

louismaximepiton
Copy link
Member

Fixes #1337

@netlify
Copy link

netlify bot commented Jun 29, 2022 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit e78fdc1
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/62d6956a82dbb20008ce0e2a
😎 Deploy Preview https://deploy-preview-1347--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond julien-deramond force-pushed the main-lmp-stepped-process-line-height branch from f648126 to e78fdc1 Compare July 19, 2022 11:28
@julien-deramond
Copy link
Member

Made some changes due to the integration of the CSS variables in the other PR. Introduced here $step-link-line-height and --#{$prefix}stepped-process-link-line-height.

@julien-deramond julien-deramond self-requested a review July 19, 2022 13:02
julien-deramond
julien-deramond approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced on Mac + Chrome. LGTM! Coherent on different platforms/browsers.

@julien-deramond julien-deramond merged commit 7c93d7d into main Jul 19, 2022
@julien-deramond julien-deramond deleted the main-lmp-stepped-process-line-height branch July 19, 2022 13:05
@julien-deramond julien-deramond mentioned this pull request Jul 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
css fix v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stepped-processs: underline not visible on hover
2 participants
@louismaximepiton @julien-deramond