Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages: Fix margin-top #1445

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Aug 8, 2022

Related to #901.
Changes the margin-top of error messages on validation inside forms.
Fix that works for .form-text too (IMO, it's better to change both at the same time for consistency).

Checks

  • Make sure that the deploy looks the same as specs (label with error).
  • Make sure that the .form-text is still ok compared to main.

@netlify
Copy link

netlify bot commented Aug 8, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit b9d1183
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6374a5ef12343300082ecde4
😎 Deploy Preview https://deploy-preview-1445--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@julien-deramond
Copy link
Member

Is it possible to enrich the description in order to get what's fixed in this PR?

@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are no design guidelines for .form-text but I agree that it is logical to modify it as well for consistency.

@julien-deramond julien-deramond merged commit 6435103 into main Nov 16, 2022
@julien-deramond julien-deramond deleted the main-lmp-validation-fix branch November 16, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants