Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: Fix compilation issue when $enable-rounded: true #1604

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

louismaximepiton
Copy link
Member

Related issues

Fixes #1508.

Description

Add an inspect function around the used Sass var in order to avoid the trailing spaces around the / to avoid it to become a division.

Motivation & Context

Even if $enable-rounded shouldn't be used in the context of Orange, let's try to make things good.

Types of change

  • Bug fix (non-breaking which fixes an issues)

Live previews

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • All new and existing tests passed

@netlify
Copy link

netlify bot commented Nov 9, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit e5514fa
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/636b852e5fbeac0008682361
😎 Deploy Preview https://deploy-preview-1604--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit f14b551 into main Nov 9, 2022
@julien-deramond julien-deramond deleted the main-lmp-enable-rounded-fix branch November 9, 2022 10:53
@julien-deramond julien-deramond mentioned this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS compilation issue when $enable-rounded: true
2 participants