Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): switch rendering on some platforms #1612

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Nov 14, 2022

Related issues

Closes #1576

Description

Force the background-position to cover a height of 100%.

Types of change

  • Bug fix (non-breaking which fixes an issues)

Live previews

⚠️ Please review the changes on all platforms/browsers combinations.

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • All new and existing tests passed

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 6b74d0e
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6371fbceef4e780008410dcb
😎 Deploy Preview https://deploy-preview-1612--boosted.netlify.app/docs/5.2/customize/color
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond julien-deramond marked this pull request as ready for review November 14, 2022 07:19
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't spot any breaking change on all devices

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit d78dae7 into main Nov 14, 2022
@julien-deramond julien-deramond deleted the main-jd-fix-switch-on-ios branch November 14, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch issue on iOS
2 participants