Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Invalid feedback line-height (with small-font-size) #1638

Merged
merged 3 commits into from
Nov 21, 2022

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Nov 18, 2022

Related issues

Closes #1588

Description

Use line-height-sm for invalid-feedback with small-font-size.

Motivation & Context

The .invalid-feedback redefined the font-size without redefining line-height.

Types of change

  • Bug fix (non-breaking which fixes an issues)

Live previews

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • My change introduces changes to the migration guide
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@netlify
Copy link

netlify bot commented Nov 18, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 43dcb9c
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/637b3459ad2c3e000829b6d1
😎 Deploy Preview https://deploy-preview-1638--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond

This comment was marked as resolved.

@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julien-deramond julien-deramond merged commit e3c6350 into main Nov 21, 2022
@julien-deramond julien-deramond deleted the main-his-invalid-feedback-line-height branch November 21, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form: Invalid feedback should have a greater line-height.
2 participants