Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar scrolling: fix missing logo #1664

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Nov 25, 2022

Description

Orange logo was missing in the scrolling example.

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issues)

Live previews

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • My change introduces changes to the migration guide
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@MewenLeHo MewenLeHo added v5 accessibility docs Improvements or additions to documentation fix labels Nov 25, 2022
@MewenLeHo MewenLeHo self-assigned this Nov 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@netlify
Copy link

netlify bot commented Nov 25, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit ef2b8d7
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6381047f6607e600082aa180
😎 Deploy Preview https://deploy-preview-1664--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@julien-deramond julien-deramond merged commit 75dee5f into main Nov 28, 2022
@julien-deramond julien-deramond deleted the main-mlh-fix-missing-logo-in-navbar-scrolling branch November 28, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility docs Improvements or additions to documentation fix v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants