Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps-dev): bump pa11y-ci-reporter-html from 4.0.0 to 5.0.2 #1712

Merged
merged 1 commit into from
Dec 16, 2022
Merged

chore(deps-dev): bump pa11y-ci-reporter-html from 4.0.0 to 5.0.2 #1712

merged 1 commit into from
Dec 16, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Dec 16, 2022 •
edited
Loading

This PR follows #1707 to finally use the latest version of pa11y-ci-reporter-html.

Here are the intermediate versions from 4.0.0 to 5.0.2:

There are only 2 breaking elements in 5.0.0:

  • "BREAKING: Dropped support for Node 12 and 17 since end-of-life"
    • This change is transparent in our case
  • "BREAKING: Updated page reports to use pa11y-reporter-html-plus instead of the built-in Pa11y HTML reporter. This includes enhanced support for all built-in Pa11y runners (htmlcs, axe), including links to relevant help, and the ability to filter accessibility issues by type."
    • We can see in the modified package-lock.json that pa11y-reporter-html-plus is gathered automatically as a dependency of pa11y-ci-reporter-html so we have nothing to do for that

How to test

This PR can be reviewed the same way as #1707. I've introduced 7015a3e so that pa11y-ci fails locally and here in the CI. This commit will be reverted just before merging the PR.

@julien-deramond julien-deramond added dependencies Pull requests that update a dependency file chore labels Dec 16, 2022
@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 7688478
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/639c295ef7ca0b0008ea604e
😎 Deploy Preview https://deploy-preview-1712--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond julien-deramond marked this pull request as ready for review December 16, 2022 06:40
louismaximepiton
louismaximepiton approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 That's much prettier now !

@julien-deramond julien-deramond force-pushed the main-jd-bump-pa11y-ci-reporter-html-5.0.2 branch from 7015a3e to 7688478 Compare December 16, 2022 08:16
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit d3163d9 into main Dec 16, 2022
@julien-deramond julien-deramond deleted the main-jd-bump-pa11y-ci-reporter-html-5.0.2 branch December 16, 2022 08:26
@julien-deramond julien-deramond mentioned this pull request Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
chore dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-deramond @louismaximepiton