New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): remove extra break line in table shortcode #1758

Merged

julien-deramond merged 2 commits into main from main-jd-fix-table-shortcode

Jan 6, 2023

Member

julien-deramond commented Jan 4, 2023 •

edited

Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Description

This PR fixes the rendering of the source code by removing an extra break line in the {{< table >}} shortcode.

Motivation & Context

This PR fixes what can be seen in https://boosted.orange.com/docs/5.2/content/tables/ where there's an extra break line at the beginning of the displayed source code in some cases:

Types of change

Bug fix (non-breaking which fixes an issues)

Live previews

Please double-check that there's no regression by using {{< table >}} in all cases:

https://deploy-preview-1758--boosted.netlify.app/docs/content/tables/

Checklist

Contribution

I have read the contributing guidelines

Accessibility

(NA) My change follows accessibility good practices; I have at least run axe

Design

(NA) My change respects the design guidelines defined in Orange Design System
(NA) My change is compatible with responsive display

Development

My change follows the developer guide
(NA) I have added JavaScript unit tests to cover my changes

Documentation

My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

(NA) My change introduces changes to the migration guide
(NA) My new component is added in Storybook
(NA) My new component is compatible with RTL
(NA) Manually run BrowserStack tests
(NA) Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
(NA) Code review
(NA) Design review
(NA) A11y review

After the merge

(NA) Manually launch Percy tests


          fix(docs): remove extra break line in table shortcode

2218b6d

julien-deramond added v5 docs fix labels

netlify bot commented Jan 4, 2023 •

edited

Loading

✅ Deploy Preview for boosted ready!

Name	Link
🔨 Latest commit	`b1dd460`
🔍 Latest deploy log	https://app.netlify.com/sites/boosted/deploys/63b80d4174a24000096826ff
😎 Deploy Preview	https://deploy-preview-1758--boosted.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

louismaximepiton approved these changes

View reviewed changes

Member

louismaximepiton left a comment

Good catch ! LGTM 🚀


          Merge branch 'main' into main-jd-fix-table-shortcode

b1dd460

sonarcloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

julien-deramond merged commit e7848dd into main

julien-deramond deleted the main-jd-fix-table-shortcode branch

January 6, 2023 12:02

julien-deramond mentioned this pull request

v5.3.0 Ship List #1762

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels