Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update footer in order to use the ic_Mobile_Network_Coverage icon #2022

Merged
merged 8 commits into from
Jul 4, 2023

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented May 3, 2023

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Update boosted sprite svg file in order to use the ic_Mobile_Network_Coverage icon instead of ic_Signal in the footer examples: download icon from DSM, update it with svgo, replace the icon in Boosted sprite file. The alignment may appear slightly to low, but on inspection it seems better than on the old version.

New version:
image

Old version:
image

I also took the opportunity to update 3 other svg paths that had empty bodies (reported as a warning by the linter).

Motivation & Context

It has been seen during a design review that the icon that was used was not the good one. DSM should be updated in the same way.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (NA) My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • (NA) My new component is compatible with RTL
  • (NA) Manually run BrowserStack tests
  • (NA) Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@netlify
Copy link

netlify bot commented May 3, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 36c0778
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64a3b76ebfd1420008734624
😎 Deploy Preview https://deploy-preview-2022--boosted.netlify.app/docs/5.3/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hannahiss hannahiss marked this pull request as ready for review May 3, 2023 07:45
@hannahiss hannahiss changed the title Update footer in order to use the ic_Mobile_Network_Coverage icon Docs: Update footer in order to use the ic_Mobile_Network_Coverage icon May 3, 2023
@hannahiss hannahiss added the docs Improvements or additions to documentation label May 3, 2023
MewenLeHo

This comment was marked as outdated.

@hannahiss
Copy link
Member Author

hannahiss commented May 11, 2023

'I also took the opportunity to update 3 other svg paths that had empty bodies (reported as a warning by the linter).'
Could it be possible to add some details please? At least the names of the '3 other svg paths' + no need to do it in a destinct PR?

I just changed the code <path xxx></path> (with empty body) to <path xxx/> (with no body) for the svgs "contact", "locate" and "protection"...

Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for design review, curious to know that they will say about the two icons 🤔

@hannahiss hannahiss self-assigned this Jun 9, 2023
@Franco-Riccitelli
Copy link

The icon looks good in the footer. No issues. Thanks.

@julien-deramond julien-deramond self-requested a review July 3, 2023 06:24
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth mentioning the fact that the icon has been modified in the migration guide, isn't it? Depending on how folks have integrated our Footer component in their project in the previous Boosted version, they won't know that they need to update it.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still find the rendering off because of the icon not filling the entire container, but LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julien-deramond julien-deramond merged commit 6b76109 into main Jul 4, 2023
14 checks passed
@julien-deramond julien-deramond deleted the his-footer-ic-network branch July 4, 2023 06:11
@julien-deramond julien-deramond mentioned this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug docs Improvements or additions to documentation passed design review v5
Projects
Development

Successfully merging this pull request may close these issues.

4 participants