-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update footer in order to use the ic_Mobile_Network_Coverage icon #2022
Conversation
… the footers instead of ic_Signal
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I just changed the code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for design review, curious to know that they will say about the two icons 🤔
The icon looks good in the footer. No issues. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth mentioning the fact that the icon has been modified in the migration guide, isn't it? Depending on how folks have integrated our Footer component in their project in the previous Boosted version, they won't know that they need to update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still find the rendering off because of the icon not filling the entire container, but LGTM!
Kudos, SonarCloud Quality Gate passed! |
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
Description
Update boosted sprite svg file in order to use the ic_Mobile_Network_Coverage icon instead of ic_Signal in the footer examples: download icon from DSM, update it with svgo, replace the icon in Boosted sprite file. The alignment may appear slightly to low, but on inspection it seems better than on the old version.
New version:
Old version:
I also took the opportunity to update 3 other svg paths that had empty bodies (reported as a warning by the linter).
Motivation & Context
It has been seen during a design review that the icon that was used was not the good one. DSM should be updated in the same way.
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge