Dark mode: Local navigation #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
# Conflicts: # site/content/docs/5.3/components/navbar.md # site/layouts/shortcodes/callout-deprecated-dark-variants.html
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
changed the title
…test page: remove alerts local bg + add new vars visualisation
Merged
Merged
louismaximepiton
approved these changes
Oct 3, 2023
| // ******* Additions for dark-mode | ||
| --#{$prefix}hover-color: #{$body-color}; | ||
| --#{$prefix}active-bg: #{$gray-400}; | ||
| --#{$prefix}disabled-color: #{$gray-500}; |
There was a problem hiding this comment.
As a first step, I'd be fine fine defining those right there, but IMHO, they should have their own Sass variables somewhere.
Fine for now but if we keep them, I like the naming though it's a bit too evasive maybe.
There was a problem hiding this comment.
Yes, variables names and way to do it are te be discussed... but for now useful and simple 😄
julien-deramond
approved these changes
Oct 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Local navigation in dark mode, by using existing css vars:
$local-nav-hover-bg= --bs-secondary-bg // from - `gray300 to gray900 under lg point$local-nav-active-color= --bs-link-hover-color // from accessible-orange to brand-orange$local-nav-border-color= --bs-border-color-translucent // from gray-500 to gray-700--bs-hover-colorto switch$local-nav-hover-colorfrom black to brand-orange--bs-active-bgto switch$local-nav-active-bgfrom gray-400 to gray-700--bs-disabled-colorto switch$form-star-rating-disabled-color,$nav-link-disabled-colorand$navbar-light-disabled-colorfrom gray-500 to gray-700 =>Links