Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Form labels & texts #2289

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 9, 2023

Description

Form checks in dark mode, by using existing and new Sass vars :

Sass var Previous value New value
$form-text-color var(--#{$prefix}secondary-color) var(--#{$prefix}placeholder-color)
$form-label-color null var(--#{$prefix}body-color)
$form-label-disabled-color $gray-500 var(--#{$prefix}disabled-color)
$form-label-required-color - var(--#{$prefix}link-hover-color)

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 9, 2023
@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit f98f71d
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6523c3da02f84700088ec697
😎 Deploy Preview https://deploy-preview-2289--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond merged commit d477f76 into main-jd-dark-mode Oct 9, 2023
17 checks passed
@julien-deramond julien-deramond deleted the main-lmp-form-label-dark branch October 9, 2023 11:39
@julien-deramond julien-deramond mentioned this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues
Projects
Development

Successfully merging this pull request may close these issues.

2 participants