Dark mode: Buttons

[louismaximepiton]

Description

• .btn-secondary becomes transparent by default -> No need of .btn-outline-secondary, keeping it for retro-compatibility. This could be easily changed if there's too much impacts.
• Dropdown toggle don't have a transparent background -> Need a question about it to the design
• Some buttons have transparent backgrounds that might be issues when used on images for example.
• Success and danger buttons don't change its default color whether on dark or light mode.
• Changing the mixin and the default number of parameters of this mixin. The minimum number of parameters could be changed but would be useless imo.
• Not using Sass Variables since Bootstrap doesn't.

Links

• https://deploy-preview-2293--boosted.netlify.app/docs/5.3/components/buttons
• https://deploy-preview-2293--boosted.netlify.app/docs/5.3/dark-mode/#buttons

[netlify]

✅ Deploy Preview for boosted ready!

Name	Link
🔨 Latest commit	420f01e
🔍 Latest deploy log	https://app.netlify.com/sites/boosted/deploys/6524fb329405ec00087fb05a
😎 Deploy Preview	https://deploy-preview-2293--boosted.netlify.app/docs/5.3/dark-mode
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[julien-deramond]

Neat! Let's merge this first version so that it unblocks other comments.

I'll the following comments within the description of the main PR:

• .btn-primary is now transparent when active; can be an issue against images
• .btn-info is now transparent when hovered; can be an issue against images
• Mention the impact of the new button-variant mixin in the migration guide
• Not a big fan of using $red instead $danger because the color doesn't change. Do we need to introduce new Sass variables for fixed functional colors?
• Do we need to drop btn-outline-secondary?
• Double check later the &:not(.dropdown-toggle-split) { use case in _dropdown.scss