Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Breadcrumb #2315

Merged
merged 2 commits into from
Oct 17, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scss/_breadcrumb.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
--#{$prefix}breadcrumb-bg: #{$breadcrumb-bg};
--#{$prefix}breadcrumb-border-radius: #{$breadcrumb-border-radius};
--#{$prefix}breadcrumb-divider-color: #{$breadcrumb-divider-color};
--#{$prefix}breadcrumb-divider-filter: #{$breadcrumb-divider-filter}; // Boosted mod
--#{$prefix}breadcrumb-item-padding-x: #{$breadcrumb-item-padding-x};
--#{$prefix}breadcrumb-item-active-color: #{$breadcrumb-active-color};
// scss-docs-end breadcrumb-css-vars
Expand Down Expand Up @@ -40,6 +41,7 @@
/* rtl:raw:
transform: scaleX(-1);
*/
filter: var(--#{$prefix}breadcrumb-divider-filter);
// End mod
}
}
Expand Down
2 changes: 2 additions & 0 deletions scss/_root.scss
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@
--#{$prefix}placeholder-color: #{$gray-700};
--#{$prefix}gray-tweak: #{$gray-900};
--#{$prefix}input-filter: #{$invert-filter};
--#{$prefix}icon-filter: none;
// ******* End additions for dark-mode
}

Expand Down Expand Up @@ -224,6 +225,7 @@
--#{$prefix}placeholder-color: #{$gray-600};
--#{$prefix}gray-tweak: #{$gray-700};
--#{$prefix}input-filter: #{none};
julien-deramond marked this conversation as resolved.
Show resolved Hide resolved
--#{$prefix}icon-filter: #{$invert-filter};
// ******* End additions for dark-mode
// scss-docs-end root-dark-mode-vars
}
Expand Down
3 changes: 2 additions & 1 deletion scss/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2043,7 +2043,8 @@ $breadcrumb-item-padding-x: $spacer * .5 !default;
$breadcrumb-margin-bottom: 1rem !default;
$breadcrumb-color: var(--#{$prefix}emphasis-color) !default; // Boosted mod
$breadcrumb-bg: null !default;
$breadcrumb-divider-color: null !default; // Boosted mod: instead of `var(--#{$prefix}secondary-color)`
$breadcrumb-divider-color: $black !default; // Boosted mod: instead of `var(--#{$prefix}secondary-color)`
$breadcrumb-divider-filter: var(--#{$prefix}icon-filter) !default; // Boosted mod
$breadcrumb-active-color: null !default; // Boosted mod: instead of `var(--#{$prefix}secondary-color)`
$breadcrumb-divider: url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 9 14' width='7' height='10'><path d='m-.4 12 2 2 7-7-7-7-2 2 5 5z'/></svg>") !default;
$breadcrumb-divider-flipped: $breadcrumb-divider !default;
Expand Down
82 changes: 82 additions & 0 deletions site/content/docs/5.3/dark-mode.md
Original file line number Diff line number Diff line change
Expand Up @@ -2111,3 +2111,85 @@ sitemap_exclude: true
<label for="excellent51" title="Excellent"><span class="visually-hidden">Excellent</span></label>
</fieldset></form>
</div>

### Breadcrumb

<h4 class="mt-3">No theme</h4>

<div class="border border-tertiary p-3">
<nav aria-label="breadcrumb1">
<ol class="breadcrumb mb-0">
<li class="breadcrumb-item"><a href="#">Home</a></li>
<li class="breadcrumb-item"><a href="#">Library</a></li>
<li class="breadcrumb-item active" aria-current="page">Data</li>
</ol>
<ol class="breadcrumb" style="--bs-breadcrumb-divider: '>';">
<li class="breadcrumb-item"><a href="#">Home</a></li>
<li class="breadcrumb-item active" aria-current="page">Library</li>
</ol>
</nav>
</div>

<h4 class="mt-3">Dark theme on container</h4>

<div class="border border-tertiary p-3 bg-body" data-bs-theme="dark">
<nav aria-label="breadcrumb2">
<ol class="breadcrumb mb-0">
<li class="breadcrumb-item"><a href="#">Home</a></li>
<li class="breadcrumb-item"><a href="#">Library</a></li>
<li class="breadcrumb-item active" aria-current="page">Data</li>
</ol>
<ol class="breadcrumb" style="--bs-breadcrumb-divider: '>';">
<li class="breadcrumb-item"><a href="#">Home</a></li>
<li class="breadcrumb-item active" aria-current="page">Library</li>
</ol>
</nav>
</div>

<h4 class="mt-3">Light theme on container</h4>

<div class="border border-tertiary p-3 bg-body" data-bs-theme="light">
<nav aria-label="breadcrumb3">
<ol class="breadcrumb mb-0">
<li class="breadcrumb-item"><a href="#">Home</a></li>
<li class="breadcrumb-item"><a href="#">Library</a></li>
<li class="breadcrumb-item active" aria-current="page">Data</li>
</ol>
<ol class="breadcrumb" style="--bs-breadcrumb-divider: '>';">
<li class="breadcrumb-item"><a href="#">Home</a></li>
<li class="breadcrumb-item active" aria-current="page">Library</li>
</ol>
</nav>
</div>

<h4 class="mt-3">Dark theme on component</h4>

<div class="border border-tertiary p-3" style="background-color: #282d55;">
<nav aria-label="breadcrumb4">
<ol class="breadcrumb mb-0" data-bs-theme="dark">
<li class="breadcrumb-item"><a href="#">Home</a></li>
<li class="breadcrumb-item"><a href="#">Library</a></li>
<li class="breadcrumb-item active" aria-current="page">Data</li>
</ol>
<ol class="breadcrumb" style="--bs-breadcrumb-divider: '>';" data-bs-theme="dark">
<li class="breadcrumb-item"><a href="#">Home</a></li>
<li class="breadcrumb-item active" aria-current="page">Library</li>
</ol>
</nav>
</div>

<h4 class="mt-3">Light theme on component</h4>

<div class="border border-tertiary p-3" style="background-color: #b5e8f7">
<nav aria-label="breadcrumb5">
<ol class="breadcrumb mb-0" data-bs-theme="light">
<li class="breadcrumb-item"><a href="#">Home</a></li>
<li class="breadcrumb-item"><a href="#">Library</a></li>
<li class="breadcrumb-item active" aria-current="page">Data</li>
</ol>
<ol class="breadcrumb" style="--bs-breadcrumb-divider: '>';" data-bs-theme="light">
<li class="breadcrumb-item"><a href="#">Home</a></li>
<li class="breadcrumb-item active" aria-current="page">Library</li>
</ol>
</nav>
</div>