Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump pa11y-ci-reporter-html from 6.0.2 to 7.0.0 #2735

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Sep 12, 2024

Description

This PR supersedes #2724 as pa11y tests are not executed in Dependabot PRs.

There are some things we need to test before merging this PR:

  • Automatic tests are green just by bumping the dependency
  • Launching the tests locally still works as expected: the HTML report is created and all green
    • npm run docs ; npm run docs-accessibility and file:///Users/xxx/Orange-Boosted-Bootstrap/.pa11y/index.html is clean
  • Create a voluntary a11y error detected by pa11y-ci by modifying build/.pa11yci.json to remove #offcanvas and #offcanvasDark rules (see 5777047)
    • CI pa11y-ci test must fail, and we should access to the HTML report
    • Locally, it must fail and generate and HTML report
      • npm run docs ; npm run docs-accessibility

Screenshot 2024-09-12 at 14 15 07
Screenshot 2024-09-12 at 14 15 02

  • Revert the fake tests

@julien-deramond julien-deramond added v5 dependencies Pull requests that update a dependency file labels Sep 12, 2024
Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 2e90abb
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66e3c7dacf76210008e0c305
😎 Deploy Preview https://deploy-preview-2735--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond
Copy link
Member Author

The only problem I see is that we can see this message: "No files were found with the provided path: .pa11y/. No artifacts will be uploaded.". And the HTML report is not available via the CI execution.

However, it's already an issue on the main branch: see https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/actions/runs/10830594602/job/30050696323#step:10:13

We could merge this PR and try to tackle the issue in a separate PR (if needed).

@vprothais
Copy link
Collaborator

Everything is fine for me. Thanks for the detailed process for testing. I learned about the tool and also checked how github actions works.
You can Revert the fake test. I agree with you, the artifact issue can be handled in another PR.

@julien-deramond julien-deramond force-pushed the main-jd-bump-pa11y-ci-reporter-html-7.0.0 branch from 5777047 to 2e90abb Compare September 13, 2024 05:04
@julien-deramond julien-deramond marked this pull request as ready for review September 13, 2024 05:04
@julien-deramond julien-deramond merged commit d8ad360 into main Sep 13, 2024
25 checks passed
@julien-deramond julien-deramond deleted the main-jd-bump-pa11y-ci-reporter-html-7.0.0 branch September 13, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file v5
Projects
Development

Successfully merging this pull request may close these issues.

2 participants