-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release v5.0.0 #670
Conversation
d4a9ebd
to
0aaa354
Compare
ff62662
to
0b06d5e
Compare
Opened a PR for DocSearch config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems very good to me, only a few tweaks here and there 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, keep going with DoD 😉
…e official brand, purple make no sense. no more than the pink in actual boosted 4
@@ -7,7 +7,7 @@ | |||
--- | |||
|
|||
<svg xmlns="http://www.w3.org/2000/svg"> | |||
<symbol id="bootstrap" viewBox="0 0 118 94"> | |||
<symbol id="bootstrap" viewBox="0 0 118 94" style="display:none"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why only hide it? Couldn't you replace SVG content with Orange's logo?
Didn't check at all where this is used, BTW :')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
display none move to svg itself
@@ -6,64 +6,6 @@ | |||
body_class: "" | |||
--- | |||
|
|||
<svg xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum so you did remove them. However they're probably called somewhere with the <use>
tag and symbol
s' id
, aren't they?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes ;-)
@@ -117,7 +117,7 @@ $background-colors: map-merge( | |||
"success": $supporting-green, | |||
"info": $supporting-blue, | |||
"warning": $supporting-yellow, | |||
"danger": $purple | |||
"danger": $danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going this way, you should probably use functional colors above too instead of supporting ones, isn't it?
Or does inconsistency acceptable here?
Definitely a topic to address wth the brand team, giving a red supporting color instead of the functional one, IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created an issue to keep track of this
This reverts commit 71aae36.
@@ -83,5 +83,5 @@ params: | |||
js_bundle_hash: "sha384-3pZoGeuGuppkOcTDkPFSq3eCeByOZjj3CQ2PRI7hTL8gCUSPno1ZKZo2yeta2U1D" | |||
popper: "https://cdn.jsdelivr.net/npm/@popperjs/core@2.9.1/dist/umd/popper.min.js" | |||
popper_hash: "sha384-SR1sx49pcuLnqZUnnPwx6FCym0wLsk5JZuNx2bPPENzswTNFaQU1RDvt3wT4gWFG" | |||
focus_visible: "https://cdn.jsdelivr.net/npm/focus-visible@5.1.0/dist/focus-visible.min.js" | |||
focus_visible: "https://cdn.jsdelivr.net/npm/focus-visible@5.2.0/dist/focus-visible.min.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If docs are using bundled JS, why do we use this? In "Getting Started" docs, maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you're the author of the callout in introduction. In case project don't use boosted JS
{{< callout warning >}}
#### Required script
Boosted includes [WICG's `:focus-visible` polyfill](https://github.com/WICG/focus-visible) to ensure an enhanced focus visibility for keyboard users while shutting down focus styles on active state.
However, if you don't need or want to use Boosted's JavaScript files, you'll still need to use the polyfill.
```html
<script src="{{< param "cdn.focus_visible" >}}" integrity="{{< param "cdn.focus_visible_hash" >}}" crossorigin="anonymous"></script>
{{< /callout >}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used in Getting Started docs indeed:
<script src="{{< param "cdn.focus_visible" >}}" integrity="{{< param "cdn.focus_visible_hash" >}}" crossorigin="anonymous"></script>```
chore(merge main): patched commit → bf09367
npm run release-version $current_version $next_version
to bump version numberversion_short
inpackage.json
_data/docs-versions.yml
docs_version
in_config.yml
CHANGELOG.md
, and maybesite/content/docs/<version>/migration.md
npm run release
to compile dist, update SRI hashes in doc and package the releaseconventional-changelog-cli
globallyconventional-changelog -p angular -i CHANGELOG.md -s
dist
with achore(release)
commit messagev5-dev
for now)gh-pages
:../bs-docs
to thegh-pages
branchindex.html
used as redirections to be redirecting to the new releasedist
URLs in examples' HTML has changednpm pack
thennpm publish
.npmrc
file--tag
, eg for v5-alpha1npm publish boosted-5.0.0-alpha1.tgz --tag next