Social button fixed #743
Merged
Social button fixed #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter clicking on social buttons
julien-deramond
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
Thank you for this PR.
Just few comments for your next contribution:
- When you create the PR to add some code into the version 5, you need to choose as base "v5-dev" and not "v4-dev".
- After some comments, you must keep the same branch to push your modifications and not create another PR (for example this one and Social button fix #740).
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(#733): prevent a redirection to the main page after clicking on social buttons