Fix active dropdown items

[vogloblinsky]

No description provided.

[julien-deramond]

Wouldn't it be better to keep this part in _dropdown.scss where (pseudo-code) color = active-color and background = active-bg?

&.active,
&:active {
  color: $dropdown-link-active-color;
  text-decoration: none;
  @include gradient-bg($dropdown-link-active-bg);
}

and rather modify _variables.scss to do:

diff --git a/scss/_variables.scss b/scss/_variables.scss
index 80614b652..1628524b4 100644
--- a/scss/_variables.scss
+++ b/scss/_variables.scss
@@ -1144,8 +1144,8 @@ $dropdown-link-color:               $black !default;
 $dropdown-link-hover-color:         $white !default;
 $dropdown-link-hover-bg:            $black !default;

-$dropdown-link-active-color:        $component-active-color !default;
-$dropdown-link-active-bg:           color-contrast($dropdown-link-active-color) !default;
+$dropdown-link-active-color:        color-contrast($component-active-color) !default; // Boosted mod
+$dropdown-link-active-bg:           $component-active-color !default;  // Boosted mod

 $dropdown-link-disabled-color:      $gray-500 !default;

Note: It only has an impact on Dark dropdowns but that doesn't seem to work anyway.

[julien-deramond]

You just need to remove your modification in scss/_dropdown.scss and this PR is ready to be merged

[julien-deramond]

🚀