chore(a11y): add missing role='search' and type='search' in navbar component and examples #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe, but check first if it's been already tried, to not waste your time 😉 |
yannickcornaille
approved these changes
Oct 6, 2021
julien-deramond
force-pushed
the
add-role-search-in-forms
branch
from
77bb20b
to
b93dddb
Compare
|
Not 100% sure but please try 😄 FWIW pa11y-ci might complain about multiple search roles in the same page. Maybe a callout to mention the role would help, too? |
…mponent and examples
julien-deramond
force-pushed
the
add-role-search-in-forms
branch
from
b93dddb
to
c83b1be
Compare
@ffoodd and/or @yannickcornaille, do the location and the content of the callout seem OK to you? (see https://deploy-preview-785--boosted.netlify.app/docs/5.1/components/navbar/#forms) |
julien-deramond
force-pushed
the
add-role-search-in-forms
branch
from
c83b1be
to
eb0d141
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Aniort pointed out to @Nurovek in his WIP development of Global Headers a missing
role=searchas an attribute of the<form>s.This PR is a proposal to apply this feedback all over Boosted documentation.
If this PR is merged, @ffoodd , do you think Bootstrap would be interested in such a modification?