Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TYPO] Fix hardcoded macro chars in TemplateProcessor method #2618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[TYPO] Fix hardcoded macro chars in TemplateProcessor method #2618

wants to merge 1 commit into from

Conversation

glafarge
Copy link

@glafarge glafarge commented Jun 4, 2024 •
edited

Description

Replace hardcoded macro chars by the customized ones in deleteRow() method of TemplateProcessor class

Checklist:

  • My CI is 馃煝
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@coveralls
Copy link

Coverage Status

coverage: 97.208%. remained the same
when pulling eb4dd2e on glafarge:patch-1
into 2daa50c on PHPOffice:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glafarge @coveralls