Handle the use-case of step = 0; and tests for exception handling for…

… invalid arguments
PHPOffice · Jan 29, 2022 · 1df4d4c · 1df4d4c
1 parent ea5a390
commit 1df4d4c
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/src/PhpSpreadsheet/Calculation/MathTrig/MatrixFunctions.php b/src/PhpSpreadsheet/Calculation/MathTrig/MatrixFunctions.php
@@ -70,6 +70,13 @@ public static function sequence($rows = 1, $columns = 1, $start = 1, $step = 1)
             return $e->getMessage();
         }
 
+        if ($step === 0) {
+            return array_chunk(
+                array_fill(0, $rows * $columns, $start),
+                $columns
+            );
+        }
+
         return array_chunk(
             range($start, $start + (($rows * $columns - 1) * $step), $step),
             $columns

diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/MathTrig/SequenceTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/MathTrig/SequenceTest.php
@@ -10,9 +10,9 @@ class SequenceTest extends AllSetupTeardown
      * @dataProvider providerSEQUENCE
      *
      * @param mixed[] $arguments
-     * @param mixed[] $expectedResult
+     * @param mixed[]|string $expectedResult
      */
-    public function testSEQUENCE(array $arguments, array $expectedResult): void
+    public function testSEQUENCE(array $arguments, $expectedResult): void
     {
         $result = MathTrig\MatrixFunctions::sequence(...$arguments);
         self::assertEquals($expectedResult, $result);

diff --git a/tests/data/Calculation/MathTrig/SEQUENCE.php b/tests/data/Calculation/MathTrig/SEQUENCE.php
@@ -81,4 +81,15 @@
             [-5, -7.5, -10],
         ],
     ],
+    [
+        [2, 2, 1, 0],
+        [
+            [1, 1],
+            [1, 1],
+        ],
+    ],
+    [
+        [2, 2, 'A', 0],
+        '#VALUE!',
+    ],
 ];