-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Xlsx Writer Formula with Bool Result of False
Fix for #2082. Xlsx Writer was writing a cell which is a formula which evaluates to boolean false as an empty XML tag. This is okay for Excel 365, but not for Excel 2016-. Change to write the tag as a value of 0 instead, which works for all Excel releases. Add test.
- Loading branch information
Showing
2 changed files
with
41 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<?php | ||
|
||
namespace PhpOffice\PhpSpreadsheetTests\Writer\Xlsx; | ||
|
||
use PhpOffice\PhpSpreadsheet\Shared\File; | ||
use PhpOffice\PhpSpreadsheet\Spreadsheet; | ||
use PhpOffice\PhpSpreadsheet\Writer\Xlsx as Writer; | ||
use PHPUnit\Framework\TestCase; | ||
|
||
class Issue2082Test extends TestCase | ||
{ | ||
public function testBoolWrite(): void | ||
{ | ||
// Problem writing boolean function values is detected only when | ||
// opening spreadsheet in Excel 2007-2016. Test verifies that | ||
// value field is written correctly for those versions. | ||
$outputFilename = File::temporaryFilename(); | ||
$spreadsheet = new Spreadsheet(); | ||
$worksheet = $spreadsheet->getActiveSheet(); | ||
$worksheet->fromArray(['A', 'B', 'C', 'D']); | ||
$worksheet->getCell('A2')->setValue('=A1<>"A"'); | ||
$worksheet->getCell('A3')->setValue('=A1="A"'); | ||
$worksheet->getCell('B2')->setValue('=LEFT(B1, 0)'); | ||
$worksheet->getCell('B3')->setValue('=B2=""'); | ||
|
||
$writer = new Writer($spreadsheet); | ||
$writer->save($outputFilename); | ||
$zipfile = "zip://$outputFilename#xl/worksheets/sheet1.xml"; | ||
$contents = file_get_contents($zipfile); | ||
unlink($outputFilename); | ||
if ($contents === false) { | ||
self::fail('Unable to open file'); | ||
} else { | ||
self::assertStringContainsString('<c r="A2" t="b"><f>A1<>"A"</f><v>0</v></c>', $contents); | ||
self::assertStringContainsString('<c r="A3" t="b"><f>A1="A"</f><v>1</v></c>', $contents); | ||
self::assertStringContainsString('<c r="B2" t="str"><f>LEFT(B1, 0)</f><v></v></c>', $contents); | ||
self::assertStringContainsString('<c r="B3" t="b"><f>B2=""</f><v>1</v></c>', $contents); | ||
} | ||
} | ||
} |