Fixed #1455 issue of border #1473
Conversation
|
Thank you for your submission. |
| $cellStyle = $sheet->getStyle($column . $row); | ||
| if (isset($attributeArray['rowspan'], $attributeArray['colspan'])) { | ||
| $columnTo = $column; | ||
| for ($i = 0; $i < (int) $attributeArray['colspan'] - 1; ++$i) { |
There was a problem hiding this comment.
Is the loop necessary? Or can the adjustment of the $columnTo value be done with simple mathematics, with conversion between character and numeric column addresses?
Might it be cleaner moving this calculation into a separate method, as it's duplicated for two cases?
There was a problem hiding this comment.
Yes Because it is incrementing the column which is A-Z and this is also used in the processDomElement on line number 504 so that is why i have used this. @MarkBaker. we can create separate method now as it is used total 4 times in the whole file.
| $cellStyle = $sheet->getStyle($range); | ||
| } elseif (isset($attributeArray['colspan'])) { | ||
| $columnTo = $column; | ||
| for ($i = 0; $i < (int) $attributeArray['colspan'] - 1; ++$i) { |
There was a problem hiding this comment.
Is the loop necessary? Or can the adjustment of the $columnTo value be done with simple mathematics, with conversion between character and numeric column addresses?
Which is the more efficient?
There was a problem hiding this comment.
Yes Because it is incrementing the column which is A-Z and this is also used in the processDomElement on line number 504 so that is why i have used this. @MarkBaker.
This is:
Checklist:
Why this change is needed?
This commit has been made to fix the #1455 issue of the border.
I have added range before applying the inline style instead of single cell to resolve border related issue #1455 .