Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader writer flags #2136

Merged
merged 13 commits into from
Jun 4, 2021
Merged

Reader writer flags #2136

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0edd5ef
First pass code to read pivot tables for Xlsx
May 9, 2021
5b00ccf
Merge branch 'master' into PivotTable-Implementation-for-Xlsx
Jun 1, 2021
dd6c9f4
Use of passing flags with Readers to identify whether speacial featur…
Jun 1, 2021
5349fe3
Use of passing flags with Writers to identify whether speacial featur…
Jun 1, 2021
1d899eb
Update documentation
Jun 1, 2021
f900ae9
Ensure that Writer save() signatures match interface definition
Jun 1, 2021
3e691d8
phpcs and phpstan appeasements
Jun 1, 2021
b89b293
Fon't brea protection keys
Jun 1, 2021
eeca2d5
More updates to the documentation
Jun 1, 2021
c28a288
Add unit test for Reader flags
Jun 1, 2021
64fdea8
Minor updates to documentation
Jun 2, 2021
e505e87
Update documentation with details of changes to the StringValueBinder
Jun 4, 2021
1ea68f9
Merge branch 'master' into Reader-Writer-Flags
Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor updates to documentation
  • Loading branch information
MarkBaker committed Jun 2, 2021
commit 64fdea8aef9e6f7bf8d21284fdcbad2c3bf503c2
4 changes: 2 additions & 2 deletions docs/topics/reading-and-writing-to-file.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,14 +1031,14 @@ $reader->load("spreadsheetWithCharts.xlsx");
```
Alternatively, you can specify this in the call to load the spreadsheet:
```php
$reader = \PhpOffice\PhpSpreadsheet\IOFactory::createReaderForFile("05featuredemo.xlsx");
$reader = \PhpOffice\PhpSpreadsheet\IOFactory::createReaderForFile("spreadsheetWithCharts.xlsx");
$reader->load("spreadsheetWithCharts.xlsx", $reader::LOAD_WITH_CHARTS);
```

If you wish to use the IOFactory `load()` method rather than instantiating a specific Reader, then you can still pass these flags.

```php
$spreadsheet = \PhpOffice\PhpSpreadsheet\IOFactory::load("setIncludeCharts.xlsx", \PhpOffice\PhpSpreadsheet\Reader\IReader::LOAD_WITH_CHARTS);
$spreadsheet = \PhpOffice\PhpSpreadsheet\IOFactory::load("spreadsheetWithCharts.xlsx", \PhpOffice\PhpSpreadsheet\Reader\IReader::LOAD_WITH_CHARTS);
```

Likewise, when saving a file using a Writer, loaded charts wil not be saved unless you explicitly tell the Writer to include them:
Expand Down