Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for Scrutinizer Initialization Problem #2759

Closed
wants to merge 7 commits into from

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Apr 20, 2022

Fix #2732, which see for details. Solution suggested by @odan.

This is:

- [ ] a bugfix
- [ ] a new feature
- [x] Scrutinizer workaround

Checklist:

Why this change is needed?

Possible Scrutinizer workaround.
@oleibman oleibman marked this pull request as draft April 20, 2022 02:19
@oleibman oleibman mentioned this pull request Apr 20, 2022
@oleibman oleibman changed the title WIP Do Not Install Workaround for Scrutinizer Initialization Problem Apr 22, 2022
@oleibman oleibman marked this pull request as ready for review April 22, 2022 04:10
@oleibman
Copy link
Collaborator Author

Failed twice now (with no real indication why), clearly too unstable to merge. Reverting to draft status, will continue to test periodically.

@oleibman oleibman marked this pull request as draft April 23, 2022 18:06
@MarkBaker
Copy link
Member

@oleibman I'm planning to do a release tomorrow or Monday; is there anything that you especially want to push through into 1.23.0?

@oleibman
Copy link
Collaborator Author

@MarkBaker #2772 is probably ready. No strong feelings about whether it should or should not be in new release.

@oleibman
Copy link
Collaborator Author

Worked this time. Still took a very long (almost 10 minutes) to set up 8.1 environment. There are approximately as many new issues introduced (14) as existing issues fixed (15) since the last successful Scrutinizer run. Results haven't convinced me to merge this change, but I will continue to test.

@oleibman
Copy link
Collaborator Author

oleibman commented Aug 14, 2022

Still very slow. Complete in 18 minutes 44 seconds on 2022-08-14. 99 new issues, 75 issues fixed, since last run. It'll probably be a mess if performance ever gets to the point when we want to enable.

Not sure whether merge from master is required or not.
@oleibman
Copy link
Collaborator Author

oleibman commented Sep 4, 2022

Good results - down to 12 new issues (11 minor 1 unknown), with 57 issues fixed. Overall time still very long (over 20 minutes excluding almost 10 minutes in queue).

@oleibman
Copy link
Collaborator Author

oleibman commented Sep 9, 2022

Down to 4 new issues. Required only about 12 minutes.

@oleibman
Copy link
Collaborator Author

Scrutinizer appears to be working this morning (2022-09-12) without this override. I will monitor for a few days, and close this ticket if that continues to be the case.

@oleibman
Copy link
Collaborator Author

Issue appears resolved. Closing ticket.

@oleibman oleibman closed this Sep 14, 2022
@oleibman oleibman deleted the bionic branch October 20, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Scrutinizer is Broken
2 participants