-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Fixes for Scatter Charts #2828
Merged
Merged
Commits on May 13, 2022
-
Chart issues have been pouring in recently. This is a partial response to issue PHPOffice#2762. It implements "no joins" for scatter charts, as well as having the reader and writer handle "point size", "line width", and "color" for markers. A new boolean property `scatterLines`, with setter and getter, is added to DataSeriesValues to handle joins (default is true which means scatter plot points *are* joined by lines). Some, but not yet all, default font properties for the chart title are handled (color and, surprisingly, font name present challenges). With these changes, sample 32readwriteScatterChart1.xlsx now looks closer to its source. There are still some differences (x-axis changes), but I think this change is already large enough. I can work on the other problems later. The code for reading charts has not yet been converted to be namespace aware. Having a tiny island of aware code in a sea of unaware makes no sense to me, so some of the new code is likewise unaware. I hope to be able to get to it eventually, but, among other considerations, it is difficult to generate suitable test cases.
Configuration menu - View commit details
-
Copy full SHA for 79a780b - Browse repository at this point
Copy the full SHA 79a780bView commit details -
Essentially the same as the corresponding Samples, but with formal assertions.
Configuration menu - View commit details
-
Copy full SHA for 29116f7 - Browse repository at this point
Copy the full SHA 29116f7View commit details -
Clean Up Some Code in Reader/Xlsx/Chart
Having added code to support default font attributes as well as element-specific font attributes for chart captions, there was duplicated code between the default and specific sections. I hope that this PR makes the code easier to follow.
Configuration menu - View commit details
-
Copy full SHA for 1591070 - Browse repository at this point
Copy the full SHA 1591070View commit details
Commits on May 14, 2022
-
Add Support for Font Name and Color to XLSX Chart Titles
XML layout for these in new files differs from what program was expecting. Not sure if program expectations were wrong, or if this is a change to Excel since initial development.
Configuration menu - View commit details
-
Copy full SHA for 57ad96c - Browse repository at this point
Copy the full SHA 57ad96cView commit details -
Handle theoretical case where Chart title has text but no font information.
Configuration menu - View commit details
-
Copy full SHA for a1fc230 - Browse repository at this point
Copy the full SHA a1fc230View commit details
Commits on May 15, 2022
-
Support Bezier Curve and Scaling of X-Axis on Scatter Plot
For Bezier, need to specify `<c:smooth>` tag in addition to already supplied `<c:scatterStyle val="smoothMarker">` For X-Axis, scatter needs to supply both X and y axis as `<c:valAx>` rather than `<c:catAx>` for X.
Configuration menu - View commit details
-
Copy full SHA for 2f623a2 - Browse repository at this point
Copy the full SHA 2f623a2View commit details
Commits on May 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cf0d320 - Browse repository at this point
Copy the full SHA cf0d320View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.