Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Fixes for Scatter Charts #2828

Merged
merged 7 commits into from
May 17, 2022
Merged

Some Fixes for Scatter Charts #2828

merged 7 commits into from
May 17, 2022

Commits on May 13, 2022

  1. Some Fixes for Scatter Charts

    Chart issues have been pouring in recently. This is a partial response to issue PHPOffice#2762. It implements "no joins" for scatter charts, as well as having the reader and writer handle "point size", "line width", and "color" for markers. A new boolean property `scatterLines`, with setter and getter, is added to DataSeriesValues to handle joins (default is true which means scatter plot points *are* joined by lines). Some, but not yet all, default font properties for the chart title are handled (color and, surprisingly, font name present challenges).
    
    With these changes, sample 32readwriteScatterChart1.xlsx now looks closer to its source. There are still some differences (x-axis changes), but I think this change is already large enough. I can work on the other problems later.
    
    The code for reading charts has not yet been converted to be namespace aware. Having a tiny island of aware code in a sea of unaware makes no sense to me, so some of the new code is likewise unaware. I hope to be able to get to it eventually, but, among other considerations, it is difficult to generate suitable test cases.
    oleibman committed May 13, 2022
    Configuration menu
    Copy the full SHA
    79a780b View commit details
    Browse the repository at this point in the history
  2. Add Formal Tests

    Essentially the same as the corresponding Samples, but with formal assertions.
    oleibman committed May 13, 2022
    Configuration menu
    Copy the full SHA
    29116f7 View commit details
    Browse the repository at this point in the history
  3. Clean Up Some Code in Reader/Xlsx/Chart

    Having added code to support default font attributes as well as element-specific font attributes for chart captions, there was duplicated code between the default and specific sections. I hope that this PR makes the code easier to follow.
    oleibman committed May 13, 2022
    Configuration menu
    Copy the full SHA
    1591070 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2022

  1. Add Support for Font Name and Color to XLSX Chart Titles

    XML layout for these in new files differs from what program was expecting. Not sure if program expectations were wrong, or if this is a change to Excel since initial development.
    oleibman committed May 14, 2022
    Configuration menu
    Copy the full SHA
    57ad96c View commit details
    Browse the repository at this point in the history
  2. Minor Improvement

    Handle theoretical case where Chart title has text but no font information.
    oleibman committed May 14, 2022
    Configuration menu
    Copy the full SHA
    a1fc230 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2022

  1. Support Bezier Curve and Scaling of X-Axis on Scatter Plot

    For Bezier, need to specify `<c:smooth>` tag in addition to already supplied `<c:scatterStyle val="smoothMarker">`
    
    For X-Axis, scatter needs to supply both X and y axis as `<c:valAx>` rather than `<c:catAx>` for X.
    oleibman committed May 15, 2022
    Configuration menu
    Copy the full SHA
    2f623a2 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Configuration menu
    Copy the full SHA
    cf0d320 View commit details
    Browse the repository at this point in the history