Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 3381 - Fix decimal precision for Scientific Number Format Mask #3382

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Issue 3381 - Fix decimal precision for Scientific Number Format Mask #3382

merged 1 commit into from
Feb 20, 2023

Conversation

MarkBaker
Copy link
Member

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Issue #3381
Formatter was hard-coded always to render 2dp, ignoring the dp required by the mask

@MarkBaker MarkBaker force-pushed the Issue-3381_Scientific-NumberFormat-Decimal-Precision branch from 1e1d9e4 to c0b60fc Compare February 20, 2023 11:20
@MarkBaker MarkBaker merged commit 15e1451 into master Feb 20, 2023
@MarkBaker MarkBaker deleted the Issue-3381_Scientific-NumberFormat-Decimal-Precision branch February 20, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkBaker