Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index overflow on data values array #748

Closed
wants to merge 3 commits into from

Conversation

guillaume-ro-fr
Copy link
Contributor

This is:

- [x] a bugfix

Checklist:

Why this change is needed?

isMultiLevelSeries function throw an error on discontinuous indices : Notice: Undefined offset: 0.

Fix index overflow on data values array for multi level detection.

Fix PHPOffice#747
@guillaume-ro-fr
Copy link
Contributor Author

Example of XML :

...
<c:val>
	<c:numRef>
		<c:f>'Worksheet'!$F$32:$F$39</c:f>
		<c:numCache>
			<c:formatCode>0.0</c:formatCode>
			<c:ptCount val="8"/>
			<c:pt idx="4">
				<c:v>3.6</c:v>
			</c:pt>
			<c:pt idx="5">
				<c:v>6.5</c:v>
			</c:pt>
		</c:numCache>
	</c:numRef>
</c:val>
...

Note the index starting at 4, not 0.

@PowerKiKi PowerKiKi closed this in 3bea6f5 Nov 11, 2018
@guillaume-ro-fr guillaume-ro-fr deleted the fix_747 branch November 12, 2018 10:14
guillaume-ro-fr added a commit to guillaume-ro-fr/PhpSpreadsheet that referenced this pull request Jun 12, 2019
Fix index overflow on data values array for multi level detection.

Fixes PHPOffice#747
Fixes PHPOffice#748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants