feat: constraint instances (#101)

* feat: constraint instances

* feat: constraint signatures

* WIP

* feat: constraint instances

* feat: constraint signatures

* WIP

* Pushing this because I need the code on another device

* Added a method to the SpecificationBuilder class (It has yet to be tested)
Removed useless test class

* Fixed the constraint arguments filter

* Refactored SpecificationBuilder

* Removed test code from controller

* Fixed the create method of the constraint instance service
Adjusted and added other tests
Added an annotation to suppress warnings in SpecificationBuilder

* Update server/src/main/java/de/uftos/services/ConstraintInstanceService.java

Co-authored-by: Daniel Dietzler <36593685+danieldietzler@users.noreply.github.com>

* Fixed typo
Changed method name
Converted a String[] to List<String>

* Fixed import

* Renamed method
Javadoc

* Suppressing tests javadoc

---------

Co-authored-by: Marco <marcodemartino23@gmail.com>

server/src/main/java/de/uftos/controller/ConstraintController.java

@@ -3,6 +3,8 @@
 import de.uftos.dto.ConstraintInstanceRequestDto;
 import de.uftos.entities.ConstraintInstance;
 import de.uftos.entities.ConstraintSignature;
+import de.uftos.repositories.database.ConstraintInstanceRepository;
+import de.uftos.repositories.database.ConstraintSignatureRepository;
 import de.uftos.services.ConstraintInstanceService;
 import de.uftos.services.ConstraintSignatureService;
 import java.util.Optional;
@@ -26,6 +28,8 @@
 public class ConstraintController {
   private final ConstraintSignatureService constraintSignatureService;
   private final ConstraintInstanceService constraintInstanceService;
+  private final ConstraintInstanceRepository constraintInstanceRepository;
+  private final ConstraintSignatureRepository constraintSignatureRepository;
 
   /**
    * Creates the constraint controller.
@@ -35,9 +39,13 @@ public class ConstraintController {
    */
   @Autowired
   public ConstraintController(ConstraintSignatureService constraintSignatureService,
-                              ConstraintInstanceService constraintInstanceService) {
+                              ConstraintInstanceService constraintInstanceService,
+                              ConstraintInstanceRepository constraintInstanceRepository,
+                              ConstraintSignatureRepository constraintSignatureRepository) {
     this.constraintSignatureService = constraintSignatureService;
     this.constraintInstanceService = constraintInstanceService;
+    this.constraintInstanceRepository = constraintInstanceRepository;
+    this.constraintSignatureRepository = constraintSignatureRepository;
   }
 
   /**

server/src/main/java/de/uftos/entities/ConstraintArgument.java

@@ -1,11 +1,15 @@
 package de.uftos.entities;
 
+import jakarta.persistence.CascadeType;
 import jakarta.persistence.Entity;
 import jakarta.persistence.GeneratedValue;
 import jakarta.persistence.GenerationType;
 import jakarta.persistence.Id;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToOne;
 import java.util.Objects;
 import lombok.Data;
+import lombok.NoArgsConstructor;
 
 /**
  * The database table for constraint arguments.
@@ -14,14 +18,22 @@
  */
 @Entity(name = "constraint_argument")
 @Data
+@NoArgsConstructor
 public class ConstraintArgument {
   @Id
   @GeneratedValue(strategy = GenerationType.UUID)
   private String id;
 
-  private String name;
+  @ManyToOne(cascade = CascadeType.ALL)
+  @JoinColumn(name = "constraint_parameter_id", nullable = false)
+  private ConstraintParameter constraintParameter;
   private String value;
 
+
+  public ConstraintArgument(String name, String value) {
+    this.value = value;
+  }
+
   @Override
   public boolean equals(Object other) {
     if (this == other) {

server/src/main/java/de/uftos/entities/ConstraintInstance.java

@@ -32,7 +32,7 @@ public class ConstraintInstance {
   private ConstraintSignature signature;
 
   @NotNull
-  @OneToMany(cascade = CascadeType.REMOVE)
+  @OneToMany(cascade = CascadeType.ALL)
   private List<ConstraintArgument> arguments;
 
   @NotNull

server/src/main/java/de/uftos/entities/ConstraintParameter.java

@@ -1,12 +1,15 @@
 package de.uftos.entities;
 
+import com.fasterxml.jackson.annotation.JsonIgnore;
 import de.uftos.dto.ResourceType;
 import jakarta.persistence.Entity;
 import jakarta.persistence.EnumType;
 import jakarta.persistence.Enumerated;
 import jakarta.persistence.GeneratedValue;
 import jakarta.persistence.GenerationType;
 import jakarta.persistence.Id;
+import jakarta.persistence.OneToMany;
+import java.util.List;
 import java.util.Objects;
 import lombok.Data;
 
@@ -23,6 +26,10 @@ public class ConstraintParameter {
 
   private String parameterName;
 
+  @JsonIgnore
+  @OneToMany(mappedBy = "constraintParameter")
+  private List<ConstraintArgument> constraintArguments;
+
   @Enumerated(EnumType.STRING)
   private ResourceType parameterType;
 

server/src/main/java/de/uftos/entities/ConstraintSignature.java

@@ -30,11 +30,11 @@ public class ConstraintSignature {
   private RewardPenalize defaultType;
 
   @NotNull
-  @OneToMany
+  @OneToMany(cascade = CascadeType.ALL)
   private List<ConstraintParameter> parameters;
 
   @JsonIgnore
-  @OneToMany(mappedBy = "signature", cascade = CascadeType.REMOVE)
+  @OneToMany(mappedBy = "signature", cascade = CascadeType.ALL)
   private List<ConstraintInstance> instances;
 
   @Override

server/src/main/java/de/uftos/repositories/database/ConstraintInstanceRepository.java

@@ -1,6 +1,9 @@
 package de.uftos.repositories.database;
 
 import de.uftos.entities.ConstraintInstance;
+import de.uftos.entities.ConstraintSignature;
+import java.util.Optional;
+import org.springframework.data.jpa.repository.JpaSpecificationExecutor;
 import org.springframework.data.repository.ListCrudRepository;
 import org.springframework.data.repository.ListPagingAndSortingRepository;
 
@@ -9,5 +12,7 @@
  */
 public interface ConstraintInstanceRepository
     extends ListPagingAndSortingRepository<ConstraintInstance, String>,
-    ListCrudRepository<ConstraintInstance, String> {
+    ListCrudRepository<ConstraintInstance, String>, JpaSpecificationExecutor<ConstraintInstance> {
+
+  Optional<ConstraintInstance> findBySignatureAndId(ConstraintSignature signature, String id);
 }

server/src/main/java/de/uftos/repositories/database/ConstraintSignatureRepository.java

@@ -1,6 +1,7 @@
 package de.uftos.repositories.database;
 
 import de.uftos.entities.ConstraintSignature;
+import org.springframework.data.jpa.repository.JpaSpecificationExecutor;
 import org.springframework.data.repository.ListCrudRepository;
 import org.springframework.data.repository.ListPagingAndSortingRepository;
 
@@ -9,5 +10,5 @@
  */
 public interface ConstraintSignatureRepository
     extends ListPagingAndSortingRepository<ConstraintSignature, String>,
-    ListCrudRepository<ConstraintSignature, String> {
+    ListCrudRepository<ConstraintSignature, String>, JpaSpecificationExecutor<ConstraintSignature> {
 }

server/src/main/java/de/uftos/services/ConstraintInstanceService.java

@@ -1,12 +1,31 @@
 package de.uftos.services;
 
 import de.uftos.dto.ConstraintInstanceRequestDto;
+import de.uftos.dto.ResourceType;
+import de.uftos.entities.ConstraintArgument;
 import de.uftos.entities.ConstraintInstance;
+import de.uftos.entities.ConstraintParameter;
+import de.uftos.entities.ConstraintSignature;
 import de.uftos.repositories.database.ConstraintInstanceRepository;
+import de.uftos.repositories.database.ConstraintSignatureRepository;
+import de.uftos.repositories.database.GradeRepository;
+import de.uftos.repositories.database.LessonRepository;
+import de.uftos.repositories.database.RoomRepository;
+import de.uftos.repositories.database.StudentGroupRepository;
+import de.uftos.repositories.database.StudentRepository;
+import de.uftos.repositories.database.SubjectRepository;
+import de.uftos.repositories.database.TagRepository;
+import de.uftos.repositories.database.TeacherRepository;
+import de.uftos.repositories.database.TimeslotRepository;
+import de.uftos.utils.SpecificationBuilder;
+import java.util.AbstractMap;
+import java.util.List;
+import java.util.Map;
 import java.util.Optional;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
+import org.springframework.data.jpa.domain.Specification;
 import org.springframework.http.HttpStatus;
 import org.springframework.stereotype.Service;
 import org.springframework.web.server.ResponseStatusException;
@@ -17,15 +36,46 @@
 @Service
 public class ConstraintInstanceService {
   private final ConstraintInstanceRepository repository;
+  private final ConstraintSignatureRepository signatureRepository;
+  private final GradeRepository gradeRepository;
+  private final LessonRepository lessonRepository;
+  private final RoomRepository roomRepository;
+  private final StudentRepository studentRepository;
+  private final StudentGroupRepository studentGroupRepository;
+  private final SubjectRepository subjectRepository;
+  private final TagRepository tagRepository;
+  private final TeacherRepository teacherRepository;
+  private final TimeslotRepository timeslotRepository;
+
 
   /**
    * Creates a constraintInstance service.
    *
    * @param repository the repository for accessing the constraintInstance entity.
    */
   @Autowired
-  public ConstraintInstanceService(ConstraintInstanceRepository repository) {
+  public ConstraintInstanceService(ConstraintInstanceRepository repository,
+                                   ConstraintSignatureRepository signatureRepository,
+                                   GradeRepository gradeRepository,
+                                   LessonRepository lessonRepository,
+                                   RoomRepository roomRepository,
+                                   StudentRepository studentRepository,
+                                   StudentGroupRepository studentGroupRepository,
+                                   SubjectRepository subjectRepository,
+                                   TagRepository tagRepository,
+                                   TeacherRepository teacherRepository,
+                                   TimeslotRepository timeslotRepository) {
     this.repository = repository;
+    this.signatureRepository = signatureRepository;
+    this.gradeRepository = gradeRepository;
+    this.lessonRepository = lessonRepository;
+    this.roomRepository = roomRepository;
+    this.studentRepository = studentRepository;
+    this.studentGroupRepository = studentGroupRepository;
+    this.subjectRepository = subjectRepository;
+    this.tagRepository = tagRepository;
+    this.teacherRepository = teacherRepository;
+    this.timeslotRepository = timeslotRepository;
   }
 
   /**
@@ -36,7 +86,36 @@ public ConstraintInstanceService(ConstraintInstanceRepository repository) {
    * @return the newly created constraint instance.
    */
   public ConstraintInstance create(String signatureId, ConstraintInstanceRequestDto request) {
-    return null;
+    ConstraintSignature signature = this.signatureRepository.findById(signatureId)
+        .orElseThrow(() -> new ResponseStatusException(HttpStatus.BAD_REQUEST));
+
+    if (signature.getParameters().size() != request.arguments().size()) {
+      throw new ResponseStatusException(HttpStatus.BAD_REQUEST);
+    }
+
+    for (ConstraintParameter parameter : signature.getParameters()) {
+      String value = request.arguments().get(parameter.getParameterName());
+      if (value == null || value.isEmpty()) {
+        throw new ResponseStatusException(HttpStatus.BAD_REQUEST,
+            "Parameter %s could not be found".formatted(parameter.getParameterName()));
+      }
+
+      boolean exists = this.getResourceTypeMapping(value).get(parameter.getParameterType());
+      if (!exists) {
+        throw new ResponseStatusException(HttpStatus.BAD_REQUEST,
+            "%s with id %s could not be found".formatted(parameter.getParameterName(),
+                parameter.getId()));
+      }
+    }
+
+    ConstraintInstance instance = new ConstraintInstance();
+    List<ConstraintArgument> arguments = request.arguments().entrySet().stream()
+        .map(item -> new ConstraintArgument(item.getKey(), item.getValue())).toList();
+    instance.setArguments(arguments);
+    instance.setSignature(signature);
+    instance.setType(request.type());
+
+    return this.repository.save(instance);
   }
 
   /**
@@ -48,7 +127,12 @@ public ConstraintInstance create(String signatureId, ConstraintInstanceRequestDt
    */
   public Page<ConstraintInstance> get(String signatureId, Pageable pageable,
                                       Optional<String> argument) {
-    return this.repository.findAll(pageable);
+    Specification<ConstraintInstance> specification = new SpecificationBuilder<ConstraintInstance>()
+        .andJoinEquals(signatureId, "signature", "name")
+        .optionalAndJoinLikeIgnoreCase(argument, "arguments", "value")
+        .build();
+
+    return this.repository.findAll(specification, pageable);
   }
 
   /**
@@ -59,7 +143,10 @@ public Page<ConstraintInstance> get(String signatureId, Pageable pageable,
    * @throws ResponseStatusException if the ID doesn't have a corresponding constraintInstance.
    */
   public ConstraintInstance getById(String signatureId, String id) {
-    return this.repository.findById(id)
+    ConstraintSignature signature = this.signatureRepository.findById(signatureId)
+        .orElseThrow(() -> new ResponseStatusException(HttpStatus.BAD_REQUEST));
+
+    return this.repository.findBySignatureAndId(signature, id)
         .orElseThrow(() -> new ResponseStatusException(HttpStatus.BAD_REQUEST));
   }
 
@@ -72,7 +159,15 @@ public ConstraintInstance getById(String signatureId, String id) {
    */
   public ConstraintInstance update(String signatureId, String id,
                                    ConstraintInstanceRequestDto request) {
-    return null;
+    ConstraintInstance instance = this.getById(signatureId, id);
+
+    List<ConstraintArgument> arguments = request.arguments().entrySet().stream()
+        .map(item -> new ConstraintArgument(item.getKey(), item.getValue())).toList();
+
+    instance.setArguments(arguments);
+    instance.setType(request.type());
+
+    return this.repository.save(instance);
   }
 
   /**
@@ -82,6 +177,32 @@ public ConstraintInstance update(String signatureId, String id,
    * @param id          the ID of the constraintInstance.
    */
   public void delete(String signatureId, String id) {
+    ConstraintInstance instance = this.getById(signatureId, id);
+
+    this.repository.delete(instance);
+  }
+
 
+  private Map<ResourceType, Boolean> getResourceTypeMapping(String id) {
+    return Map.ofEntries(
+        new AbstractMap.SimpleEntry<>(ResourceType.GRADE,
+            this.gradeRepository.findById(id).isPresent()),
+        new AbstractMap.SimpleEntry<>(ResourceType.LESSON,
+            this.lessonRepository.findById(id).isPresent()),
+        new AbstractMap.SimpleEntry<>(ResourceType.ROOM,
+            this.roomRepository.findById(id).isPresent()),
+        new AbstractMap.SimpleEntry<>(ResourceType.STUDENT,
+            this.studentRepository.findById(id).isPresent()),
+        new AbstractMap.SimpleEntry<>(ResourceType.STUDENT_GROUP,
+            this.studentGroupRepository.findById(id).isPresent()),
+        new AbstractMap.SimpleEntry<>(ResourceType.SUBJECT,
+            this.subjectRepository.findById(id).isPresent()),
+        new AbstractMap.SimpleEntry<>(ResourceType.TAG,
+            this.tagRepository.findById(id).isPresent()),
+        new AbstractMap.SimpleEntry<>(ResourceType.TEACHER,
+            this.teacherRepository.findById(id).isPresent()),
+        new AbstractMap.SimpleEntry<>(ResourceType.TIMESLOT,
+            this.timeslotRepository.findById(id).isPresent())
+    );
   }
 }

server/src/main/java/de/uftos/services/ConstraintSignatureService.java

@@ -6,6 +6,7 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
+import org.springframework.data.jpa.domain.Specification;
 import org.springframework.http.HttpStatus;
 import org.springframework.stereotype.Service;
 import org.springframework.web.server.ResponseStatusException;
@@ -35,7 +36,11 @@ public ConstraintSignatureService(ConstraintSignatureRepository repository) {
    * @return the page of the entries fitting the parameters.
    */
   public Page<ConstraintSignature> get(Pageable pageable, Optional<String> name) {
-    return this.repository.findAll(pageable);
+    Specification<ConstraintSignature> specification = Specification.where(
+        ((root, query, cb) -> cb.like(cb.lower(root.get("id")),
+            "%" + name.orElse("").toLowerCase() + "%")));
+
+    return this.repository.findAll(specification, pageable);
   }
 
   /**