Afs/landing slope dive #16158
Merged
Afs/landing slope dive #16158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please use PX4 Discuss or Slack to align on pull requests if necessary. You can then open draft pull requests to get early feedback.
Describe problem solved by this pull request
Functions in the Landingslope class evaluate heading differences without wrapping pi.
Describe your solution
Add wrap_pi to LandingSlope.cpp functions to protect against returning zero when we don't want to.
Describe possible alternatives
Use get_vector_to_next_waypoint() instead of get_bearing_to_next_waypoint() to get a two 2-d vectors and evaluate the angle between them using the dot product.
Test data / coverage
Tested in simulation using a mission with a south-facing landing and a strong crosswind to move the vehicle off course.
Additional context
Fixes #16132