Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize pyreader #13815

Merged
merged 7 commits into from
Nov 8, 2018
Merged

optimize pyreader #13815

merged 7 commits into from
Nov 8, 2018

Conversation

jacquesqiao
Copy link
Member

No description provided.

@jacquesqiao jacquesqiao mentioned this pull request Oct 11, 2018
Closed
@jacquesqiao jacquesqiao mentioned this pull request Oct 12, 2018
Closed
typhoonzero
typhoonzero approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please make sure the test case could cover previous failing cases.

panyx0718
panyx0718 approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@panyx0718 panyx0718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG API

@jacquesqiao jacquesqiao merged commit 5b7a9dd into PaddlePaddle:develop Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panyx0718 panyx0718 panyx0718 approved these changes

@typhoonzero typhoonzero typhoonzero approved these changes

@sneaxiy sneaxiy Awaiting requested review from sneaxiy

@seiriosPlus seiriosPlus Awaiting requested review from seiriosPlus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacquesqiao @panyx0718 @typhoonzero