cherry picked windows patches. #14046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wopeizl
reviewed
Nov 2, 2018
| #define CUDNN_ENFORCE(condition) \ | ||
| do { \ | ||
| cudnnStatus_t status = condition; \ | ||
| if (UNLIKELY(status != CUDNN_STATUS_SUCCESS)) { \ | ||
| PADDLE_THROW(::paddle::platform::cudnnGetErrorString(status)); \ | ||
| } \ | ||
| } while (false) | ||
| #else |
There was a problem hiding this comment.
UNLIKELY 在paddle/fluid/inference/analysis/argument.h 做了条件编译，这里就不需要分别处理了
There was a problem hiding this comment.
在 paddle/fluid/platform/enforce.h 里
There was a problem hiding this comment.
cudnn_helper.h里加和unlikely没关系，
是因为PADDLE_THROW windows不会抛栈，用std::cerr << 输出cudnn错误。
There was a problem hiding this comment.
是修复cudnn时候的，加入PADDLE_ENFORCE抛栈，可以去掉这一块。
wopeizl
previously approved these changes
Nov 2, 2018
wopeizl
approved these changes
Nov 5, 2018
wopeizl
previously approved these changes
Nov 7, 2018
wopeizl
approved these changes
Nov 8, 2018
wopeizl
approved these changes
Nov 8, 2018
wopeizl
approved these changes
Nov 8, 2018
|
请研发老师们注意：pr中如果涉及对/doc目录的改动，reviewer请加shanyi15，多谢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.