Optimize thread pool #14259
Merged
Optimize thread pool #14259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… optimize-thread-pool test=develop
test=develop
jacquesqiao
force-pushed
the
optimize-thread-pool
branch
from
e883305
to
4062f00
Compare
|
May be use thread pool under thirdparty is OK. |
typhoonzero
approved these changes
Nov 7, 2018
|
what's the gain of this optimization? |
panyx0718
reviewed
Nov 7, 2018
| tasks_.push(std::move(task)); | ||
| { | ||
| std::unique_lock<std::mutex> lock(mutex_); | ||
| if (!running_) { |
There was a problem hiding this comment.
Is this running_ check needed?
There was a problem hiding this comment.
I think we need it, but it can work if not add.
| @@ -57,10 +57,10 @@ ThreadPool::ThreadPool(int num_threads) : running_(true) { | |||
| ThreadPool::~ThreadPool() { | |||
| { | |||
| // notify all threads to stop running | |||
| std::lock_guard<std::mutex> l(mutex_); | |||
| std::unique_lock<std::mutex> l(mutex_); | |||
There was a problem hiding this comment.
No, here just want to be consistent with other place.
| } | ||
| scheduled_.notify_all(); |
There was a problem hiding this comment.
some doc said notify_all doesn't need lock. But in reality, I see lots of projects locking this
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs:
https://stackoverflow.com/questions/44387584/double-free-or-corruption-prev-error-when-working-with-threads-and-mutex
https://stackoverflow.com/questions/17101922/do-i-have-to-acquire-lock-before-calling-condition-variable-notify-one
https://www.justsoftwaresolutions.co.uk/threading/implementing-a-thread-safe-queue-using-condition-variables.html