Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix jit on mac #14274

Merged
merged 1 commit into from
Nov 6, 2018
Merged

fix jit on mac #14274

merged 1 commit into from
Nov 6, 2018

Conversation

tensor-tang
Copy link
Contributor

@tensor-tang tensor-tang commented Nov 6, 2018 •
edited
Loading

fix #14271

test=develop

@tensor-tang
fix jit on mac
b81e1b6 
test=develop
gongweibao
gongweibao reviewed Nov 6, 2018
View reviewed changes
paddle/fluid/operators/math/jit_kernel_blas.cc
#include "paddle/fluid/operators/math/jit_kernel_macro.h"
#include "paddle/fluid/platform/enforce.h"

#ifdef PADDLE_WITH_XBYAK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who will define it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paddle/cmake/external/xbyak.cmake

Lines 15 to 19 in 8fc05e0

set(WITH_XBYAK ON)
if(WIN32 OR APPLE)
SET(WITH_XBYAK OFF CACHE STRING "Disable XBYAK in Windows and MacOS" FORCE)
return()
endif()

Let's why failed on Mac

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@heavengate
Copy link
Contributor

Build success in my Mac after pick this commit

@tensor-tang
Copy link
Contributor Author

Thanks @heavengate

gongweibao
gongweibao approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tensor-tang tensor-tang merged commit e6cfdf6 into PaddlePaddle:develop Nov 6, 2018
@tensor-tang tensor-tang deleted the fix/jit branch November 6, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongweibao gongweibao gongweibao approved these changes

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

@luotao1 luotao1 Awaiting requested review from luotao1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jit在mac上编译问题
3 participants
@tensor-tang @heavengate @gongweibao