Imperative transfer gru unit #16095
Merged
Imperative transfer gru unit #16095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
velconia
commented
Mar 7, 2019
•
velconia
commented
- transfer gru unit layer
- support imperative check in op test's check_output
- Add Layers UT for gru
test=develop
… transfer_gru_unit
… transfer_gru_unit test=develop
… transfer_gru_unit
test=develop
panyx0718
previously approved these changes
Mar 11, 2019
| and concatenation of :math:`u_t`, :math:`r_t` and :math:`m_t`. | ||
|
|
||
| Args: | ||
| input (Variable): The fc transformed input value of current step. |
There was a problem hiding this comment.
OK, I'll add it in next PR
| self._dtype = dtype | ||
| size = size // 3 | ||
| # create weight | ||
| self._weight = self.create_parameter( |
There was a problem hiding this comment.
I'm thinking. maybe we should make parameter public so people can use it.
There was a problem hiding this comment.
Can't agree more~
test=develop
panyx0718
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.