Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize recurrent_op using Prepare and RunPreparedContext, avoiding create operators in every iter. #17689

Merged
merged 1 commit into from
May 30, 2019
Merged

Optimize recurrent_op using Prepare and RunPreparedContext, avoiding create operators in every iter. #17689

merged 1 commit into from
May 30, 2019

Conversation

Xreki
Copy link
Contributor

@Xreki Xreki commented May 28, 2019 •
edited
Loading

ExecutorPrepareContext can be reused, and there is no need to create in every iters in recurrent_op. This PR is tested in PaddingRNN padding model.

model before after speedup
small 142.8 116.2 23%
large 170.5 148.4 15%

@Xreki
Optimize recurrent_op using Prepare and RunPreparedContext, avoiding …
fdf2ede 
…create operators in every iter.

test=develop
@Xreki Xreki requested review from sneaxiy and chengduoZH May 29, 2019 11:25
sneaxiy
sneaxiy approved these changes May 29, 2019
View reviewed changes
Copy link
Collaborator

@sneaxiy sneaxiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Xreki Xreki merged commit 2704479 into PaddlePaddle:develop May 30, 2019
@Xreki Xreki deleted the core_op_recurrent branch April 15, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sneaxiy sneaxiy sneaxiy approved these changes

@chengduoZH chengduoZH Awaiting requested review from chengduoZH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xreki @sneaxiy