Fix slice op shape=-1 bug #18107
Merged
Fix slice op shape=-1 bug #18107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiabinYang
reviewed
Jun 14, 2019
| start = std::min(start, dim_value); | ||
| end = std::min(end, dim_value); | ||
| start = std::min(start, end); | ||
| PADDLE_ENFORCE_GT(end, start, "end should greater than start"); |
There was a problem hiding this comment.
should this check before line 56, and in this way maybe we don't need line 56?
|
|
||
| step_in++; | ||
| } | ||
| } |
There was a problem hiding this comment.
how about change a way to implement this it looks weird to using an while(true) loop
python/paddle/fluid/framework.py
Outdated
| @@ -787,6 +787,7 @@ def _sliceAndConcatVar(self, item, axis): | |||
| return self._cloneVar(True) | |||
| start, stop, step = self._slice_indices(item, self.shape[axis]) | |||
| if step == 1: | |||
| print("22", start) | |||
|
|
||
| step_in++; | ||
| } | ||
| } |
There was a problem hiding this comment.
can we change a way to impl this it looks weird with a while(true)
phlrain
added a commit
to phlrain/Paddle
that referenced
this pull request
Jun 20, 2019
* fix slice op bug; test=develop * fix variabel test bug; test=develop * remove slice while true; test=develop
phlrain
added a commit
that referenced
this pull request
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复slice 再遇到shape=-1情况的bug
已经增加desrease dim的功能