-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dygraph api doc for web #18550
Conversation
merge to local
merge to local
merge to local
merg to local
keep update
update to local
merge to local
… fix-doc-20190708
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments
@@ -46,7 +47,7 @@ | |||
__all__ += base.__all__ | |||
__all__ += nn.__all__ | |||
__all__ += tracer.__all__ | |||
__all__ += profiler.__all__ | |||
# __all__ += profiler.__all__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about just delete it instead of comment it off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
from paddle.fluid import core | ||
from paddle.fluid import framework | ||
from .tracer import Tracer | ||
import logging | ||
|
||
__all__ = [ | ||
'enabled', | ||
'no_grad', | ||
'guard', | ||
'to_variable', | ||
] | ||
|
||
|
||
def enabled(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a TODO, we need to remove this since it always cause recurrent dependence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for api.spec
__all__