Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dygraph api doc for web #18550

Merged
merged 13 commits into from
Jul 10, 2019
Merged

Conversation

junjun315
Copy link
Contributor

@junjun315 junjun315 commented Jul 8, 2019

  1. remove dygraph.enable from __all__
  2. hidden dygraph. profiler
  3. add doc to dygraph. no_grad

@junjun315 junjun315 requested a review from JiabinYang July 9, 2019 07:33
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

@@ -46,7 +47,7 @@
__all__ += base.__all__
__all__ += nn.__all__
__all__ += tracer.__all__
__all__ += profiler.__all__
# __all__ += profiler.__all__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about just delete it instead of comment it off

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

from paddle.fluid import core
from paddle.fluid import framework
from .tracer import Tracer
import logging

__all__ = [
'enabled',
'no_grad',
'guard',
'to_variable',
]


def enabled():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a TODO, we need to remove this since it always cause recurrent dependence

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@junjun315 junjun315 requested a review from JiabinYang July 9, 2019 08:18
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for api.spec

@junjun315 junjun315 merged commit b6d5c74 into PaddlePaddle:develop Jul 10, 2019
@junjun315 junjun315 deleted the fix-doc-20190708 branch July 10, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants