Downgrade gcc to 4.8 #18614
Merged
Downgrade gcc to 4.8 #18614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhhsplendid
reviewed
Jul 12, 2019
Dockerfile
Outdated
| @@ -166,4 +195,4 @@ RUN mkdir /var/run/sshd | |||
| RUN echo 'root:root' | chpasswd | |||
| RUN sed -ri 's/^PermitRootLogin\s+.*/PermitRootLogin yes/' /etc/ssh/sshd_config | |||
| RUN sed -ri 's/UsePAM yes/#UsePAM yes/g' /etc/ssh/sshd_config | |||
| EXPOSE 22 | |||
| EXPOSE 22 | |||
There was a problem hiding this comment.
A small format issue, add end of line at last line. Other things LGTM
zhhsplendid
previously approved these changes
Jul 16, 2019
zhhsplendid
approved these changes
Jul 17, 2019
gavin1332
pushed a commit
to gavin1332/Paddle
that referenced
this pull request
Jul 18, 2019
* test=develop, fix docker with paddle nccl problem * test=develop, downgrade gcc to 4.8 for latest-dev * test=develop, downgrade gcc to 4.8 for latest-dev * test=develop, modify cmake to renew all third_party * test=develop, invoke ci * test=develop, invoke ci * test=develop, complie python with wide-unicode * test=deveop, refine env settings * test=deveop, refine env settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will downgrade gcc to 4.8 for latest-dev, we test it on these case:
And this downgrade will cause link error on Debug mode which I fixed in PR #18558
Some question has already been answered in PR #18462