-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support tensor input for ctc align op #18887
support tensor input for ctc align op #18887
Conversation
… develop update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
除了一处命名不合适外,没有其它问题。可以根据需要先merge,后续另提PR修改命名。
@@ -56,6 +56,11 @@ class CTCAlignOpMaker : public framework::OpProtoAndCheckerMaker { | |||
"(bool, default: true), whether to " | |||
"merge repeated elements between two blanks. ") | |||
.SetDefault(true); | |||
// add attr padding number for tensor input | |||
AddAttr<int>("padding_num", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
padding_num
这个名字不太合适吧,用padding_value
或其它更合适的名字?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,我再提个pr修改下命名
support tensor input for ctc align op. when input is tensor, output is also tensor with padding.