Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support tensor input for ctc align op #18887

Merged
merged 10 commits into from
Aug 5, 2019

Conversation

slf12
Copy link
Contributor

@slf12 slf12 commented Jul 30, 2019

support tensor input for ctc align op. when input is tensor, output is also tensor with padding.

Copy link
Contributor

@wanghaoshuang wanghaoshuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

除了一处命名不合适外,没有其它问题。可以根据需要先merge,后续另提PR修改命名。

@@ -56,6 +56,11 @@ class CTCAlignOpMaker : public framework::OpProtoAndCheckerMaker {
"(bool, default: true), whether to "
"merge repeated elements between two blanks. ")
.SetDefault(true);
// add attr padding number for tensor input
AddAttr<int>("padding_num",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

padding_num这个名字不太合适吧,用padding_value或其它更合适的名字?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,我再提个pr修改下命名

@wanghaoshuang wanghaoshuang changed the title support tensor input for ctc align op test=develop support tensor input for ctc align op Aug 5, 2019
@wanghaoshuang wanghaoshuang merged commit faf6890 into PaddlePaddle:develop Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants