Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checking for the fetch_list of Executor.run #18957

Merged
merged 7 commits into from
Aug 5, 2019
Merged

Add checking for the fetch_list of Executor.run #18957

merged 7 commits into from
Aug 5, 2019

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Aug 1, 2019 •
edited
Loading

fix #17254

chengduozh added 3 commits August 1, 2019 13:47
@chengduoZH chengduoZH requested a review from luotao1 August 1, 2019 06:18
remove fetch var check
db88a0b 
test=develop
update exector
11ffe92 
test=develop
luotao1
luotao1 previously approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fix bug
2788455 
test=develop
lanxianghit
lanxianghit previously approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cyj1986
cyj1986 previously approved these changes Aug 2, 2019
View reviewed changes
add list convert
7e62ba3 
test=develop
@chengduoZH chengduoZH dismissed stale reviews from cyj1986 and lanxianghit via 7e62ba3 August 5, 2019 04:46
kuke
kuke approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xreki
Xreki approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chengduoZH chengduoZH merged commit 01c7daa into PaddlePaddle:develop Aug 5, 2019
@luotao1 luotao1 mentioned this pull request Oct 24, 2019
Closed
@SigureMo SigureMo mentioned this pull request Oct 25, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuke kuke kuke approved these changes

@wanghaoshuang wanghaoshuang wanghaoshuang approved these changes

@Xreki Xreki Xreki approved these changes

@luotao1 luotao1 luotao1 left review comments

@cyj1986 cyj1986 cyj1986 left review comments

@lanxianghit lanxianghit lanxianghit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

executor.run的fetch_list如果直接给Variable。运行会hang住。
7 participants
@chengduoZH @kuke @luotao1 @wanghaoshuang @Xreki @cyj1986 @lanxianghit