Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test=develop, fix memory leak in dygraph #18998

Merged
merged 1 commit into from
Aug 5, 2019
Merged

test=develop, fix memory leak in dygraph #18998

merged 1 commit into from
Aug 5, 2019

Conversation

JiabinYang
Copy link
Contributor

This PR will fix memory leak caused by name_scope usage from optimizer in dygraph

@JiabinYang JiabinYang requested a review from sneaxiy August 5, 2019 05:13
@JiabinYang JiabinYang mentioned this pull request Aug 5, 2019
Closed
sneaxiy
sneaxiy approved these changes Aug 5, 2019
View reviewed changes
Copy link
Collaborator

@sneaxiy sneaxiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

chengduoZH
chengduoZH approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@chengduoZH chengduoZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chengduoZH chengduoZH merged commit af63b11 into PaddlePaddle:develop Aug 5, 2019
@JiabinYang JiabinYang deleted the fix_mem_leak branch January 14, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengduoZH chengduoZH chengduoZH approved these changes

@sneaxiy sneaxiy sneaxiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JiabinYang @chengduoZH @sneaxiy