enable self-defined index data in testLayerGrad. #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
reviewed
Aug 14, 2017
paddle/gserver/tests/LayerGradUtil.h
Outdated
| @@ -97,6 +98,23 @@ struct InputDef { | |||
|
|
|||
| InputDef(InputType type, | |||
| string nameIn, | |||
| std::vector<int> ids, | |||
| std::vector<int> selfDefinedSeqStartPos = {}, | |||
| std::vector<int> selfDefinedSubSeqStartPos = {}) | |||
There was a problem hiding this comment.
std::vector -> const std::vector&
另外，InputDef的构造函数被加的太多了，以后set/get函数好一些~
There was a problem hiding this comment.
对，现在构造函数确实非常多。
done
qingqing01
approved these changes
Aug 14, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable defining Argument.ids in testLayerGrad.