clang format with version check #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clang-format-version-check
reyoung
reviewed
Aug 16, 2017
|
|
||
| if ! [[ $version == *"$VERSION"* ]]; then | ||
| echo "clang-format version check failed." | ||
| echo "a version contains '$VERSION' is needed, but get '$version'" |
There was a problem hiding this comment.
Do not quote variable with ''.
There was a problem hiding this comment.
My fault, it could display well.
reyoung
reviewed
Aug 16, 2017
.clang_format.hook
Outdated
| if ! [[ $version == *"$VERSION"* ]]; then | ||
| echo "clang-format version check failed." | ||
| echo "a version contains '$VERSION' is needed, but get '$version'" | ||
| echo "you can install the right version, and make an soft-link to /usr/bin/clang-format" |
There was a problem hiding this comment.
Not necessary in /usr/bin. Maybe in PATH is good enough.
you can install the right version and put it in '$PATH'
reyoung
approved these changes
Aug 16, 2017
|
It seems that this merge should be squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #3356