[CUSTOM]custom device add black_list #50409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
qili93
reviewed
Feb 13, 2023
| @@ -141,7 +141,8 @@ phi::KernelKey FallBackToCpu(const phi::KernelKey& kernel_key, | |||
| #endif | |||
| #ifdef PADDLE_WITH_CUSTOM_DEVICE | |||
| auto place = phi::TransToPhiPlace(kernel_key.backend()); | |||
| if (platform::is_custom_place(place)) { | |||
| if (platform::is_custom_place(place) || | |||
| phi::backends::custom_device::is_in_custom_black_list(op.Type())) { | |||
| VLOG(3) << "phi missing " << place.GetDeviceType() | |||
| << " kernel: " << op.Type() | |||
| << ", expected_kernel_key:" << kernel_key | |||
There was a problem hiding this comment.
这里修改下 VLOG 信息，目前提示都是 missing kernel 的，加上 black list 的提示
qili93
reviewed
Feb 13, 2023
paddle/phi/core/kernel_factory.cc
Outdated
| #elif defined(PADDLE_WITH_CUSTOM_DEVICE) | ||
| if ((FLAGS_enable_api_kernel_fallback && kernel_iter == iter->second.end()) || | ||
| phi::backends::custom_device::is_in_custom_black_list( | ||
| TransToFluidOpName(kernel_name)) |
There was a problem hiding this comment.
这里的判断逻辑需要修改下，当 FLAGS_enable_api_kernel_fallback = False 的时候，任何情况都不会 fallback 算子到 CPU 上，会直接报错。因此这里需要修改为：
FLAGS_enable_api_kernel_fallback && (FLAGS_enable_api_kernel_fallback || is_in_custom_black_list(...))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
Add black_list 4 custom_device plugin.
Use env var
$CUSTOM_DEVICE_BLACK_LISTto enable this feature.example:
export CUSTOM_DEVICE_BLACK_LIST=op-1, op-2, ...