[AMP OP&Test] add fp16/bf16 unittest for softmax_with_cross_entropy ops #52412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ZzSean
reviewed
Apr 7, 2023
| self.dtype = np.uint16 | ||
|
|
||
| # NOTE: numpy bf16 have very low accuracy, use float32 for numpy check. | ||
| date_type = np.float32 if core.is_compiled_with_rocm() else np.float64 |
ZzSean
reviewed
Apr 7, 2023
|
|
||
| def test_check_output(self): | ||
| if self.python_api is not None: | ||
| self.check_output(atol=1e-2) |
ZzSean
reviewed
Apr 7, 2023
|
|
||
| def test_check_grad(self): | ||
| if self.python_api is not None: | ||
| self.check_grad(["Logits"], "Loss", max_relative_error=0.1) |
There was a problem hiding this comment.
这里的max_relative_error尝试使用默认值看能否通过，若不能再调整
|
fp16的单测需要尝试默认的 |
ZzSean
reviewed
Apr 10, 2023
| @@ -508,12 +509,12 @@ def setUp(self): | |||
|
|
|||
| def test_check_output(self): | |||
| if self.python_api is not None: | |||
| self.check_output(atol=1e-2) | |||
| self.check_output() | |||
| self.check_output(atol=1e-2) | |||
ZzSean
reviewed
Apr 10, 2023
| @@ -917,6 +918,53 @@ def initParams(self): | |||
| self.use_softmax = True | |||
|
|
|||
|
|
|||
| class TestSoftmaxWithCrossEntropyOpBF16(TestSoftmaxWithCrossEntropyOp): | |||
ZzSean
reviewed
Apr 10, 2023
| self.attrs['axis'] = self.axis | ||
|
|
||
| def test_check_output(self): | ||
| if self.python_api is not None: |
There was a problem hiding this comment.
调用check_output/grad_with_place，否则会跑到CPU报错
YuanRisheng
approved these changes
Apr 10, 2023
luotao1
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
add fp16/bf16 unittest for softmax_with_cross_entropy