[PHI] register c_comm_init_all_op to phi #59672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
20 tasks
From00
reviewed
Dec 7, 2023
| @@ -0,0 +1,34 @@ | |||
| /* Copyright (c) 2019 PaddlePaddle Authors. All Rights Reserved. | |||
| namespace operators { | ||
|
|
||
| template <typename T, typename DeviceContext> | ||
| class CCommInitAllCpuKernel : public framework::OpKernel<T> { |
There was a problem hiding this comment.
这个算子只支持GPU/XPU，可以直接不注册CPU kernel。
| protected: | ||
| phi::KernelKey GetExpectedKernelType( | ||
| const framework::ExecutionContext& ctx) const override { | ||
| return phi::KernelKey(framework::proto::VarType::FP32, ctx.GetPlace()); |
There was a problem hiding this comment.
这段逻辑是原来就有的吗？
没来是没有的，我看有其他Kernel里面是这样处理没有input的Kernel的, 比如 CSyncCommStreamOp
| @@ -0,0 +1,47 @@ | |||
| /* Copyright (c) 2019 PaddlePaddle Authors. All Rights Reserved. | |||
| @@ -0,0 +1,80 @@ | |||
| /* Copyright (c) 2019 PaddlePaddle Authors. All Rights Reserved. | |||
| namespace ops = paddle::operators; | ||
|
|
||
| PD_REGISTER_STRUCT_KERNEL( | ||
| c_comm_init_all, GPU, ALL_LAYOUT, ops::CCommInitAllKernel, float, double) {} |
There was a problem hiding this comment.
这种op没有输入输出，kernel应该只需要注册一个特定的数据类型就行了
Aurelius84
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
将 c_comm_init_all_op 注册到 PHI 体系下