Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【paddle_test No.31、32】replace cc_test with paddle_test #60959

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

xiaoyewww
Copy link
Contributor

PR types

Others

PR changes

Others

Description

#60793

Copy link

paddle-bot bot commented Jan 18, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jan 18, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jan 19, 2024
@xiaoyewww xiaoyewww changed the title 【paddle_test No.32】replace cc_test with paddle_test 【paddle_test No.31, No.31】replace cc_test with paddle_test Jan 24, 2024
@xiaoyewww xiaoyewww changed the title 【paddle_test No.31, No.31】replace cc_test with paddle_test 【paddle_test No.31, No.32】replace cc_test with paddle_test Jan 24, 2024
@xiaoyewww
Copy link
Contributor Author

@luotao1 @risemeup1 @Galaxy1458 麻烦各位佬看一下这个windows ci为啥没过,触发好几次都没有通过

@Galaxy1458
Copy link
Contributor

@luotao1 @risemeup1 @Galaxy1458 麻烦各位佬看一下这个windows ci为啥没过,触发好几次都没有通过

HI,paddle_test()这个方法原则上不需要DEPS,除非是DEPS在test阶段产生(往往以test_, _tester等开头或结尾),在这个PR中,出现了符号重定义问题,是因为重复链接库所导致,所有paddle_test()的所有DEPS都需删除。可了解下[cmake治理]删除paddle_test多余无用依赖任务

@xiaoyewww xiaoyewww force-pushed the paddle_test_32 branch 4 times, most recently from 2d7a230 to 01d6d98 Compare February 1, 2024 15:16
@xiaoyewww
Copy link
Contributor Author

@luotao1 @risemeup1 @Galaxy1458 麻烦各位佬看一下这个windows ci为啥没过,触发好几次都没有通过

HI,paddle_test()这个方法原则上不需要DEPS,除非是DEPS在test阶段产生(往往以test_, _tester等开头或结尾),在这个PR中,出现了符号重定义问题,是因为重复链接库所导致,所有paddle_test()的所有DEPS都需删除。可了解下[cmake治理]删除paddle_test多余无用依赖任务

@Galaxy1458 在windows上,这个flags_native_test的UT,如果不去掉paddle_flags依赖,会出现重链接库的现象,如果去掉,会出现unresolved external symbol,我这边没有windows环境可以测试,请问这个依赖该怎么添加呢,是需要修改代码吗?

@xiaoyewww xiaoyewww mentioned this pull request Feb 4, 2024
@luotao1 luotao1 merged commit bab377b into PaddlePaddle:develop Feb 19, 2024
30 checks passed
@luotao1 luotao1 changed the title 【paddle_test No.31, No.32】replace cc_test with paddle_test 【paddle_test No.31、32】replace cc_test with paddle_test Feb 19, 2024
@xiaoyewww xiaoyewww deleted the paddle_test_32 branch May 10, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants