【CINN】Add DSL test case for rope of llama #61130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhhsplendid
reviewed
Jan 24, 2024
| class origin: | ||
| @to_cinn_llir | ||
| def fn_rotary( | ||
| A: DataArray((1, -1, 1, 512)), |
There was a problem hiding this comment.
Add another test case that replaces the first 1 to 64?
There was a problem hiding this comment.
We should replace it with a symbol indeed, but dsl don't support it, so temporarily we use a constant shape 1, maybe this can be a TODO
| var_2: DataArray((1, -1, 1, 256)), | ||
| var_3: DataArray((1, -1, 1, 512)), | ||
| C: DataArray((1, -1, 1, 512)), | ||
| index: DataArray((2, 1), dtype=common.Int(32)), |
There was a problem hiding this comment.
Can this type be Int(64), since we will use int64 for shape now? So I guess the index value should be Int(64)?
| @@ -165,8 +165,124 @@ def elementwise_add_inline_gt( | |||
| assert_llir_equal(elementwise_add_inline, elementwise_add_inline_gt) | |||
|
|
|||
|
|
|||
| def test_llama_rope_compute_inline(): | |||
There was a problem hiding this comment.
It is not complete rope, maybe write "xxx_xxx_pattern"
eee4017
pushed a commit
to eee4017/Paddle
that referenced
this pull request
Jan 30, 2024
* add slice * rename test case and use int64 to indexing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
pcard-72718
This pr add DSL test case for rope of llama
Here we construct a gather + slice + concat + multiply to simulate calculation logic of rope in llama