Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IPU] fix ProgressBar quiting error #2123

Merged
merged 1 commit into from
May 12, 2022
Merged

[IPU] fix ProgressBar quiting error #2123

merged 1 commit into from
May 12, 2022

Conversation

gglin001
Copy link
Contributor

PR types

Bug fixes

PR changes

Models

Description

使用原始的 ProgressBar 会导致训练结束后程序退出时出现 segmentation fault(不会影响到训练过程), 添加 ProgressFunc 修复了这个问题

ZeyuChen
ZeyuChen approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions.

@ZeyuChen
Copy link
Member

@gglin001 我们会移动bert目录至根目录model_zoo下，将一些质量较高想要主推的模型放到更顶层的目录让开发者了解到，后续GraphCore同学可以在新的目录下开发。

@ZeyuChen ZeyuChen merged commit d9b2e10 into PaddlePaddle:develop May 12, 2022
@gglin001
Copy link
Contributor Author

@gglin001 我们会移动bert目录至根目录model_zoo下，将一些质量较高想要主推的模型放到更顶层的目录让开发者了解到，后续GraphCore同学可以在新的目录下开发。

好的👍🏼

@gglin001 gglin001 deleted the fix_compilation_progress_logger branch May 12, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeyuChen ZeyuChen ZeyuChen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gglin001 @ZeyuChen